Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Modify 4rth parameter TypedArray.h function Create() to take a const T* instead of a T*

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bsurender, Assigned: bsurender)

Tracking

unspecified
mozilla17
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Change TypedArray::Create(...) parameter 4 from T* data = NULL to a const T* data.

Comment 1

5 years ago
r=me. ;)
(Assignee)

Comment 2

5 years ago
Created attachment 649893 [details] [diff] [review]
Create() 4rth arg changed to const T* and remaining changes as appropriate.
Attachment #649893 - Flags: review?(bzbarsky)

Comment 3

5 years ago
Comment on attachment 649893 [details] [diff] [review]
Create() 4rth arg changed to const T* and remaining changes as appropriate.

Review of attachment 649893 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/TypedArray.h
@@ +63,5 @@
>    {}
>  
>    static inline JSObject*
>    Create(JSContext* cx, nsWrapperCache* creator, uint32_t length,
> +         const T* data) {

We need to keep the = NULL here. The function has a default parameter.
(Assignee)

Comment 4

5 years ago
(In reply to Eric Faust from comment #3)
> Comment on attachment 649893 [details] [diff] [review]
> Create() 4rth arg changed to const T* and remaining changes as appropriate.
> 
> Review of attachment 649893 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/bindings/TypedArray.h
> @@ +63,5 @@
> >    {}
> >  
> >    static inline JSObject*
> >    Create(JSContext* cx, nsWrapperCache* creator, uint32_t length,
> > +         const T* data) {
> 
> We need to keep the = NULL here. The function has a default parameter.

ah yep agreed. my bad. deleted the = NULL. :)
(Assignee)

Comment 5

5 years ago
Created attachment 649905 [details] [diff] [review]
TypedArray.h Create(...) 4rth parameter fix
Attachment #649893 - Attachment is obsolete: true
Attachment #649893 - Flags: review?(bzbarsky)
Attachment #649905 - Flags: review?(bzbarsky)

Comment 6

5 years ago
Comment on attachment 649905 [details] [diff] [review]
TypedArray.h Create(...) 4rth parameter fix

r=me
Attachment #649905 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

5 years ago
Attachment #649905 - Flags: checkin?(bzbarsky)

Updated

5 years ago
Whiteboard: checkin-needed

Comment 7

5 years ago
For what it's worth, it would be good to have better checkin comments for patches you want someone else to push (like the actual checkin comment you want).

https://hg.mozilla.org/integration/mozilla-inbound/rev/5556678cfd6c
Flags: in-testsuite-
Whiteboard: checkin-needed
Target Milestone: --- → mozilla17

Updated

5 years ago
Attachment #649905 - Flags: checkin?(bzbarsky) → checkin+

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5556678cfd6c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.