781046 - Modify 4rth parameter TypedArray.h function Create() to take a const T* instead of a T*

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[bsurender]

Change TypedArray::Create(...) parameter 4 from T* data = NULL to a const T* data.

Comment 1

[Boris Zbarsky [:bzbarsky]]

r=me. ;)

Comment 2

[bsurender]

Attachment: Create() 4rth arg changed to const T* and remaining changes as appropriate.

Comment 3

[Eric Faust [:efaust]]

Comment on attachment 649893 [details] [diff] [review]
Create() 4rth arg changed to const T* and remaining changes as appropriate.

Review of attachment 649893 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/TypedArray.h
@@ +63,5 @@
>    {}
>  
>    static inline JSObject*
>    Create(JSContext* cx, nsWrapperCache* creator, uint32_t length,
> +         const T* data) {

We need to keep the = NULL here. The function has a default parameter.

Comment 4

[bsurender]

(In reply to Eric Faust from comment #3)
> Comment on attachment 649893 [details] [diff] [review]
> Create() 4rth arg changed to const T* and remaining changes as appropriate.
> 
> Review of attachment 649893 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/bindings/TypedArray.h
> @@ +63,5 @@
> >    {}
> >  
> >    static inline JSObject*
> >    Create(JSContext* cx, nsWrapperCache* creator, uint32_t length,
> > +         const T* data) {
> 
> We need to keep the = NULL here. The function has a default parameter.

ah yep agreed. my bad. deleted the = NULL. :)

Comment 5

[bsurender]

Attachment: TypedArray.h Create(...) 4rth parameter fix

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 649905 [details] [diff] [review]
TypedArray.h Create(...) 4rth parameter fix

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

For what it's worth, it would be good to have better checkin comments for patches you want someone else to push (like the actual checkin comment you want).

https://hg.mozilla.org/integration/mozilla-inbound/rev/5556678cfd6c

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5556678cfd6c