781104 - turn source of XBL properties and fields off

Status: RESOLVED WONTFIX

(Core :: XBL, defect)

Description

[:Benjamin Peterson]

Attachment: turn source off for XBL properties and field defaults

As far as I can tell, the own way to get the underlying functions on properties is contortions like this:

Object.getOwnPropertyDescriptor(Object.getPrototypeOf(document.getElementById("content")), "visibleTabs").get

That of course doesn't mean that no one is relying on having the source of XBL properties. If it turns out too many addons need it, it can be easily restored.

If this goes well, perhaps method source can be disabled, too.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

The reason for this bug is?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 649984 [details] [diff] [review]
turn source off for XBL properties and field defaults

At least CompileFunction should have good explanation why one would want to
pass false as the last parameter.

And in general, I'm against special casing, so unless there is
some good reason for this bug, I don't see the point.

Comment 3

[:Benjamin Peterson]

It reduces runtime memory usage and startup time.

Comment 4

[:Benjamin Peterson]

Attachment: turn source off for XBL properties and field defaults

Trying again with comment on CompileFunction.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Doesn't this change make debugging possibly harder in some cases?
Also, how much memory is actually saved with this change?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 655484 [details] [diff] [review]
turn source off for XBL properties and field defaults

Sorry that I'm so reluctant to take this kind of special case, but
this makes code more complicated. So, I want to see some numbers showing that
this is actually beneficial.

Also, what does .toSource() return if source is not saved?

Comment 7

[:Benjamin Peterson]

These days we need to keep the source around for lazy parsing and such, so there's not much to be gained here anymore.