781111 - Should use nsByteArray::GetBufferPos() for md5 hash string

Status: NEW

(MailNews Core :: Backend, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

There are some unconditional characters on GetSize().

Comment 1

[:Irving Reid (No longer working on Firefox)]

Comment on attachment 649993 [details] [diff] [review]
Fix

Review of attachment 649993 [details] [diff] [review]:
-----------------------------------------------------------------

I think I understand this change, but it would have been helpful to have a more detailed explanation in the bug report and patch description.

Here's what I think the fix is:

The nsMsgLineBuffer has an allocated size, returned by GetSize(), which is larger than the amount of actual data we read - so the existing code using GetSize() is hashing our line plus all the junk occupying the rest of the buffer

Changing to GetBufferPos() means that we only hash from the beginning of the buffer to the end of the actual data written to the buffer.

My r+ is based on this assumption; if my analysis is not correct please cancel the r+ and add more explanation to the bug.

Comment 2

[Ludovic Hirlimann [:Usul]]

Hiro shall we set checking needed for this patch ?