Report CPU usage for hung Flash processes

RESOLVED FIXED in mozilla17

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gfritzsche, Assigned: gfritzsche)

Tracking

17 Branch
mozilla17
All
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 5 obsolete attachments)

(Assignee)

Description

5 years ago
Followup to bug 764660. Collect & report CPU usage for the Flash processes too when Flash hung.
(Assignee)

Comment 1

5 years ago
Created attachment 650152 [details] [diff] [review]
Add Flash process CPU usage reporting
(Assignee)

Updated

5 years ago
Attachment #650152 - Flags: review?(benjamin)
(Assignee)

Comment 2

5 years ago
Created attachment 650156 [details] [diff] [review]
Add Flash process CPU usage reporting

Accidentally uploaded the wrong patch.
Attachment #650152 - Attachment is obsolete: true
Attachment #650152 - Flags: review?(benjamin)
Attachment #650156 - Flags: review?(benjamin)
Attachment #650156 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 650198 [details] [diff] [review]
Add Flash process CPU usage reporting

Added missing commit message.
Attachment #650156 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Note: this patch is based on bug 781133.
Keywords: checkin-needed
This is bitrotted. Please rebase.
Keywords: checkin-needed
(In reply to Ryan VanderMeulen from comment #5)
> This is bitrotted. Please rebase.

Nevermind me.
https://hg.mozilla.org/integration/mozilla-inbound/rev/fccc68cc904f
Flags: in-testsuite-
This was backed out due to causing Win64 build failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/40e59c86c2b3

https://tbpl.mozilla.org/php/getParsedLog.php?id=14237753&tree=Mozilla-Inbound

e:/builds/moz2_slave/m-in-w64/build/dom/plugins/ipc/PluginModuleParent.cpp(317) : error C2065: 'mFlashProcess1' : undeclared identifier

e:/builds/moz2_slave/m-in-w64/build/dom/plugins/ipc/PluginModuleParent.cpp(317) : error C2065: 'mFlashProcess1' : undeclared identifier

e:/builds/moz2_slave/m-in-w64/build/dom/plugins/ipc/PluginModuleParent.cpp(320) : error C2065: 'mFlashProcess2' : undeclared identifier

e:/builds/moz2_slave/m-in-w64/build/dom/plugins/ipc/PluginModuleParent.cpp(320) : error C2065: 'mFlashProcess2' : undeclared identifier
(Assignee)

Comment 9

5 years ago
Created attachment 650447 [details] [diff] [review]
Add Flash process CPU usage reporting

Fix missing "#ifdef MOZ_CRASHREPORTER_INJECTOR".

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=86efe3cba06a
(Assignee)

Comment 10

5 years ago
Created attachment 650496 [details] [diff] [review]
Add Flash process CPU usage reporting

* Rebased on patch 781133, attachment 650475 [details] [diff] [review]
* Fixed remaining issues
* Try: https://tbpl.mozilla.org/?tree=Try&rev=16ff9fd62753

I wonder how i even got this through my local tests yesterday.
Attachment #650198 - Attachment is obsolete: true
Attachment #650447 - Attachment is obsolete: true
(Assignee)

Comment 11

5 years ago
Comment on attachment 650496 [details] [diff] [review]
Add Flash process CPU usage reporting

Try build results are fine. Benjamin, can you do a follow review?
Attachment #650496 - Flags: review?(benjamin)
Attachment #650496 - Flags: review?(benjamin) → review+
(Assignee)

Comment 12

5 years ago
Created attachment 653440 [details] [diff] [review]
Add Flash process CPU usage reporting

Rebased on patch for bug 781133
Attachment #650496 - Attachment is obsolete: true
(Assignee)

Comment 13

5 years ago
Checkin note: This is based on patch 653426 on bug 781133.
Keywords: checkin-needed
Green on Try (the Android R2 failure is unrelated).
https://tbpl.mozilla.org/?tree=Try&rev=cfba471376c9

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c81cb568cb4
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4c81cb568cb4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.