Closed
Bug 781124
Opened 13 years ago
Closed 13 years ago
Report CPU usage for hung Flash processes
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
Details
Attachments
(1 file, 5 obsolete files)
|
5.93 KB,
patch
|
Details | Diff | Splinter Review |
Followup to bug 764660. Collect & report CPU usage for the Flash processes too when Flash hung.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #650152 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Accidentally uploaded the wrong patch.
Attachment #650152 -
Attachment is obsolete: true
Attachment #650152 -
Flags: review?(benjamin)
Attachment #650156 -
Flags: review?(benjamin)
|
||
Updated•13 years ago
|
Attachment #650156 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Added missing commit message.
Attachment #650156 -
Attachment is obsolete: true
|
||
Comment 6•13 years ago
|
||
(In reply to Ryan VanderMeulen from comment #5)
> This is bitrotted. Please rebase.
Nevermind me.
|
|
||
Comment 7•13 years ago
|
||
Flags: in-testsuite-
|
|
||
Comment 8•13 years ago
|
||
This was backed out due to causing Win64 build failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/40e59c86c2b3
https://tbpl.mozilla.org/php/getParsedLog.php?id=14237753&tree=Mozilla-Inbound
e:/builds/moz2_slave/m-in-w64/build/dom/plugins/ipc/PluginModuleParent.cpp(317) : error C2065: 'mFlashProcess1' : undeclared identifier
e:/builds/moz2_slave/m-in-w64/build/dom/plugins/ipc/PluginModuleParent.cpp(317) : error C2065: 'mFlashProcess1' : undeclared identifier
e:/builds/moz2_slave/m-in-w64/build/dom/plugins/ipc/PluginModuleParent.cpp(320) : error C2065: 'mFlashProcess2' : undeclared identifier
e:/builds/moz2_slave/m-in-w64/build/dom/plugins/ipc/PluginModuleParent.cpp(320) : error C2065: 'mFlashProcess2' : undeclared identifier
|
|
Assignee | |
Comment 9•13 years ago
|
||
Fix missing "#ifdef MOZ_CRASHREPORTER_INJECTOR".
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=86efe3cba06a
|
|
Assignee | |
Comment 10•13 years ago
|
||
* Rebased on patch 781133, attachment 650475 [details] [diff] [review]
* Fixed remaining issues
* Try: https://tbpl.mozilla.org/?tree=Try&rev=16ff9fd62753
I wonder how i even got this through my local tests yesterday.
Attachment #650198 -
Attachment is obsolete: true
Attachment #650447 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 11•13 years ago
|
||
Comment on attachment 650496 [details] [diff] [review]
Add Flash process CPU usage reporting
Try build results are fine. Benjamin, can you do a follow review?
Attachment #650496 -
Flags: review?(benjamin)
|
|
||
Updated•13 years ago
|
Attachment #650496 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 12•13 years ago
|
||
Rebased on patch for bug 781133
Attachment #650496 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 13•13 years ago
|
||
Checkin note: This is based on patch 653426 on bug 781133.
Keywords: checkin-needed
|
|
||
Comment 14•13 years ago
|
||
Green on Try (the Android R2 failure is unrelated).
https://tbpl.mozilla.org/?tree=Try&rev=cfba471376c9
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c81cb568cb4
Keywords: checkin-needed
|
|
||
Comment 15•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•