Closed Bug 781153 Opened 7 years ago Closed 7 years ago

ArchiveReader doesn't support zip-in-zip archives

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 1 obsolete file)

ArchiveReader doesn't support zip-in-zip archives
This patch:

1. implements the ArchiveInputStream as nsISeekableStream.
2. removes the ref between ArchiveInputStream and ArchiveReader.

The test_archive_zip_in_zip contains the 42.zip ( http://en.wikipedia.org/wiki/Zip_bomb - http://www.securityfocus.com/bid/3027/exploit/ ).

Should I write something about copyright/license? I wrote few lines in the test but maybe it's not enough.
Attachment #650212 - Flags: review?(jst)
I have replaced the 42.zip with a smaller and easier zip file created by me.
Attachment #650212 - Attachment is obsolete: true
Attachment #650212 - Flags: review?(jst)
Attachment #651678 - Flags: review?(jst)
Comment on attachment 651678 [details] [diff] [review]
Bug 781153 - ArchiveReader doesn't support zip-in-zip archives

Looks good! r=jst
Attachment #651678 - Flags: review?(jst) → review+
Attachment #651678 - Flags: checkin?
Comment on attachment 651678 [details] [diff] [review]
Bug 781153 - ArchiveReader doesn't support zip-in-zip archives

http://hg.mozilla.org/integration/mozilla-inbound/rev/f450fe554bd6
Attachment #651678 - Flags: checkin? → checkin+
Assignee: nobody → amarchesini
https://hg.mozilla.org/mozilla-central/rev/f450fe554bd6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.