Last Comment Bug 781153 - ArchiveReader doesn't support zip-in-zip archives
: ArchiveReader doesn't support zip-in-zip archives
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Andrea Marchesini (:baku)
:
Mentors:
Depends on: 783863
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-08 06:11 PDT by Andrea Marchesini (:baku)
Modified: 2012-08-19 02:28 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Bug 781153 - ArchiveReader doesn't support zip-in-zip archives (102.29 KB, patch)
2012-08-08 11:11 PDT, Andrea Marchesini (:baku)
no flags Details | Diff | Splinter Review
Bug 781153 - ArchiveReader doesn't support zip-in-zip archives (16.45 KB, patch)
2012-08-14 03:30 PDT, Andrea Marchesini (:baku)
jst: review+
jst: checkin+
Details | Diff | Splinter Review

Description Andrea Marchesini (:baku) 2012-08-08 06:11:15 PDT
ArchiveReader doesn't support zip-in-zip archives
Comment 1 Andrea Marchesini (:baku) 2012-08-08 11:11:51 PDT
Created attachment 650212 [details] [diff] [review]
Bug 781153 - ArchiveReader doesn't support zip-in-zip archives

This patch:

1. implements the ArchiveInputStream as nsISeekableStream.
2. removes the ref between ArchiveInputStream and ArchiveReader.

The test_archive_zip_in_zip contains the 42.zip ( http://en.wikipedia.org/wiki/Zip_bomb - http://www.securityfocus.com/bid/3027/exploit/ ).

Should I write something about copyright/license? I wrote few lines in the test but maybe it's not enough.
Comment 2 Andrea Marchesini (:baku) 2012-08-14 03:30:15 PDT
Created attachment 651678 [details] [diff] [review]
Bug 781153 - ArchiveReader doesn't support zip-in-zip archives

I have replaced the 42.zip with a smaller and easier zip file created by me.
Comment 3 Johnny Stenback (:jst, jst@mozilla.com) 2012-08-15 11:02:39 PDT
Comment on attachment 651678 [details] [diff] [review]
Bug 781153 - ArchiveReader doesn't support zip-in-zip archives

Looks good! r=jst
Comment 4 Johnny Stenback (:jst, jst@mozilla.com) 2012-08-17 18:05:35 PDT
Comment on attachment 651678 [details] [diff] [review]
Bug 781153 - ArchiveReader doesn't support zip-in-zip archives

http://hg.mozilla.org/integration/mozilla-inbound/rev/f450fe554bd6
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-18 04:26:30 PDT
https://hg.mozilla.org/mozilla-central/rev/f450fe554bd6

Note You need to log in before you can comment on or make changes to this bug.