781169 - Tweak aboutApps strings

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement, P3)

Description

[Aaron Train [:aaronmt]]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/locales/en-US/chrome/aboutApps.dtd#10

Nit: Can we change noApps.middle from: 'app store' to 'Mozilla Marketplace'

Enhancement: Should there be provided a sentence summary here about what Web Apps are? On an empty about:apps there's plenty of room in the existing container.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #0)
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/locales/en-US/
> chrome/aboutApps.dtd#10
> 
> Nit: Can we change noApps.middle from: 'app store' to 'Mozilla Marketplace'

Sure

> Enhancement: Should there be provided a sentence summary here about what Web
> Apps are? On an empty about:apps there's plenty of room in the existing
> container.

Passing on this for now

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Simply changes "app store" to "Mozilla Marketplace" and bumps the entity

Comment 3

[Wesley Johnston (:wesj)]

This is going to be 1% of 1% of 1% of users, but I do wonder about people who don't want to use the Mozilla apps store. What I like about what we have right now is that its easy to change (except for some icon issues....)

This string is likely also going to piss off localizers. Is there a better way to fix it?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Wesley Johnston (:wesj) from comment #3)
> This is going to be 1% of 1% of 1% of users, but I do wonder about people
> who don't want to use the Mozilla apps store. What I like about what we have
> right now is that its easy to change (except for some icon issues....)

Not a priority right now though.

> This string is likely also going to piss off localizers. Is there a better
> way to fix it?

How? We use the same "pre", middle", "post" scheme as desktop uses for such things.

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 650140 [details] [diff] [review]
patch

Review of attachment 650140 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, you're right about the pre-middle-post stuff. Thanks.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d03d9f932d60

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d03d9f932d60