Closed
Bug 781239
Opened 13 years ago
Closed 13 years ago
manifestparser command line broken
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Assigned: k0scist)
References
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
setup.py points to `manifestparser:main`. This should be
`manifestparser.manifestparser:main`. Also, the program doesn't tell
you how to list commands. This should be added to the description.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #650199 -
Flags: review?(wlachance)
Blocks: 781105
Assignee: nobody → jhammel
Status: NEW → ASSIGNED
Comment on attachment 650199 [details] [diff] [review]
fix
Sorry William for stealing this review but it's blocking my work for Mozmill. So I have tested it and everything works fine. Thanks Jeff.
The only thing I would propose to change is the description line to:
description = """%s. Use `help` to display commands""" % __doc__
Attachment #650199 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
pushed with suggested fix: https://github.com/mozilla/mozbase/commit/57ca9823f665d203d804e844c1b7078ae3a56ad0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•