Closed
Bug 781274
Opened 12 years ago
Closed 12 years ago
Enable StrictMode's red screen flashing on unofficial builds
Categories
(Firefox for Android Graveyard :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
WONTFIX
Firefox 17
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
1.79 KB,
patch
|
blassey
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Starting with Honeycomb, StrictMode can flash a red rectangle to warn violations: http://developer.android.com/reference/android/os/StrictMode.ThreadPolicy.Builder.html#penaltyFlashScreen%28%29 More annoying warning options include crashing or a (non-fatal) dialog box. But I think these are too aggressive. We currently enable StrictMode in unofficial builds: local, Nightly, and Aurora.
Attachment #650215 -
Flags: review?(blassey.bugs)
Updated•12 years ago
|
Attachment #650215 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 1•12 years ago
|
||
Green tryserver run: https://tbpl.mozilla.org/?tree=Try&rev=6db4694cc2bf
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1c1113cdf3e
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a1c1113cdf3e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
status-firefox17:
--- → fixed
Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 650215 [details] [diff] [review] enable-StrictMode-penaltyFlashScreen.patch [Approval Request Comment] Bug caused by (feature/regressing bug #): N/A User impact if declined: None. This is a debugging feature that only activates itself in Nightly and Aurora builds. Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): Low risk. This debugging feature already exists; my patch just tweaks how it works on Android >= Honeycomb. String or UUID changes made by this patch: N/A
Attachment #650215 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #650215 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a7e88d150acb
status-firefox15:
--- → wontfix
status-firefox16:
--- → fixed
Assignee | ||
Comment 6•12 years ago
|
||
I backed out of m-a because, after some discussion, I think this will cause more user confusion than it's worth. https://hg.mozilla.org/releases/mozilla-aurora/rev/2129954bde52
status-firefox15:
wontfix → ---
status-firefox16:
fixed → ---
Assignee | ||
Comment 7•12 years ago
|
||
I backed out of m-c, too. https://hg.mozilla.org/mozilla-central/rev/16932b475002
status-firefox17:
fixed → ---
Resolution: FIXED → WONTFIX
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•