Closed Bug 781286 Opened 10 years ago Closed 10 years ago

duplicate entries in staging buildbot configs for r5 slaves

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task, P3)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: rail)

Details

Attachments

(5 files, 1 obsolete file)

I see two entries for 090 and some other slaves on my staging master.
Hmm, 
http://hg.mozilla.org/build/buildbot-configs/rev/5aba8ed85758 added new lion build slaves, but some of them are still marked as "dev/pp" in slavealloc...
Assignee: nobody → rail
Attachment #650318 - Flags: review?(bhearsum)
Attachment #650318 - Flags: review?(bhearsum) → review+
Can we make sure that bulidbot + slavealloc agree on where these slaves should be?
Comment on attachment 650318 [details] [diff] [review]
rm staging lion slaves

http://hg.mozilla.org/build/buildbot-configs/rev/216895ff8a49

New tests will be ready soon
Attachment #650318 - Flags: checked-in+
Attached patch tests (obsolete) — Splinter Review
* Use STAGING_SLAVES variable to simplify the tests
* Drop test_preprod_vs_stag: we don't use a separate list for preproduction anymore
* Drop test_prod_is_subset_of_stag: the current config extends staging slave list
* Add test_stag_not_in_prod: check that staging-only slaves and production slaves have nothing in common.
Attachment #650864 - Flags: review?(bhearsum)
Attachment #650864 - Flags: review?(bhearsum) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
It breaks mozilla-tests/test. Needs a workaround.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Priority: -- → P3
Attached patch tests v2Splinter Review
I refactored mozilla-tests/{stagin,preproduction}_config.py to not duplicate slave entries and meet new tests.
Attachment #650864 - Attachment is obsolete: true
Attachment #654232 - Flags: review?(bhearsum)
Attachment #654232 - Flags: review?(bhearsum) → review+
This made it into production today.
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
I think this broke new staging master creation, at the very least.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This is the output from 14a926adf2ea when I put a

import pprint
pprint.pprint(SLAVES)

in staging_config.py.  Notice it's a dict, which is important for http://hg.mozilla.org/build/buildbot-configs/file/a6480010748d/mozilla-tests/universal_master_sqlite.cfg#l75
This is after; SLAVES is a list of tuples, breaking slaves.keys().
Comment on attachment 657492 [details] [diff] [review]
fix mozilla-tests staging slaves

Ahhhh, right, I forgot about dict() :/
Attachment #657492 - Flags: review?(rail) → review+
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Comment on attachment 657492 [details] [diff] [review]
fix mozilla-tests staging slaves

This is in production now.
Product: mozilla.org → Release Engineering
QA Contact: other → armenzg
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.