Closed Bug 781310 Opened 11 years ago Closed 10 years ago

nsPluginHost::GetInst() should return already_AddRefed

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: johns, Assigned: jst)

References

Details

Attachments

(1 file)

Fix.
6.98 KB, patch
johns
: review+
Details | Diff | Splinter Review 
nsPluginHost::GetInst() is a bit odd, and some of its users look questionable. It should return already_AddRefed, and its callers should be checked for sanity.
I ran into this and decided to write up a fix. Patch coming up.
Attached patch Fix. — — Splinter Review 

        Attachment #727368 -
        Flags: review?(jschoenick)

    
  

        Attachment #727368 -
        Flags: review?(jschoenick) → review+

    
  
Assignee: jschoenick → jst

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e3ad8585b8e6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.