nsPluginHost::GetInst() should return already_AddRefed

RESOLVED FIXED in mozilla22

Status

()

Product:
Core
Component:
Plug-ins
Type:
defect
Status:
RESOLVED FIXED
Opened:
7 years ago
Updated:
7 years ago

People

(Reporter: johns, Assigned: jst)

Tracking

Version:
Trunk
Target:
mozilla22
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Fix.
6.98 KB, patch
johns
: review+
Details | Diff | Splinter Review 
nsPluginHost::GetInst() is a bit odd, and some of its users look questionable. It should return already_AddRefed, and its callers should be checked for sanity.
I ran into this and decided to write up a fix. Patch coming up.
Posted patch Fix. — — Splinter Review
Attachment #727368 - Flags: review?(jschoenick)
Attachment #727368 - Flags: review?(jschoenick) → review+
Assignee: jschoenick → jst
https://hg.mozilla.org/mozilla-central/rev/e3ad8585b8e6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.