nsPluginHost::GetInst() should return already_AddRefed

RESOLVED FIXED in mozilla22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: johns, Assigned: jst)

Tracking

Trunk
mozilla22
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
nsPluginHost::GetInst() is a bit odd, and some of its users look questionable. It should return already_AddRefed, and its callers should be checked for sanity.
I ran into this and decided to write up a fix. Patch coming up.
Created attachment 727368 [details] [diff] [review]
Fix.
Attachment #727368 - Flags: review?(jschoenick)
(Reporter)

Updated

6 years ago
Attachment #727368 - Flags: review?(jschoenick) → review+
(Reporter)

Updated

6 years ago
Assignee: jschoenick → jst

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/e3ad8585b8e6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.