781330 - limit swizzling fix for bug 678607 to non-clang compilers

Status: RESOLVED INCOMPLETE

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

We should limit the swizzling fix for bug 678607 to non-clang compilers. It's unnecessary with clang.

Comment 1

[Josh Aas]

Attachment: fix v1.0

Comment 2

[Josh Aas]

We use clang for trunk Mac OS X builds now so we'll stop using this code in Mozilla builds with this patch.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Josh, so you're saying that the bug fixed by the patch for bug 678607 doesn't happen with builds compiled using clang?

How do you know this?  What sort of tests did you run?

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Note that the long discussion about blocks at bug 678607 is irrelevant to that bug's crashes.

Comment 5

[Josh Aas]

I can't reproduce the original 2-finger swipe bug on OS X 10.8 with clang and the patch I posted here. I tried swiping around for 10 minutes. I don't have a 10.7 machine to test with. Can you test to see if the swizzling is still necessary on 10.7?

Comment 6

[Steven Michaud [:smichaud] (Retired)]

> Can you test to see if the swizzling is still necessary on 10.7?

I should be able to get to it sometime next week.

First I'll need to find STR that "work" on 10.7 in builds (without the patch for bug 678607) made with gcc (bug 678607 is a little vague about STR).  Then I'll see if the STR also "work" on 10.8.  Then I'll need to test on both 10.7 and 10.8 using a build made with clang.

Comment 7

[Josh Aas]

Reassigning to Steven since he is doing the testing, but this isn't a high-priority bug right now.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 9

[Marco Castelluccio [:marco]]

Sorry, there was a problem with the detection of inactive users. There was no action for a while so I won't revert the change, but feel free to reassign it to yourself in case you're still planning to work on this.

Comment 10

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 11

[Steven Michaud [:smichaud] (Retired)]

This is left over from when I was a Mozilla employee. I'll never get back to it.