Makefile generation doesn't preserve line endings

RESOLVED WONTFIX

Status

Firefox Build System
General
RESOLVED WONTFIX
6 years ago
5 months ago

People

(Reporter: gps, Unassigned)

Tracking

Trunk
All
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
It looks like Makefile generation in the post bug 774032 world is writing CRLF line endings on Windows. My source tree has LF line endings in the Makefile.in's and when the Makefile is written in the object directory, line endings are converted to CRLF.

It appears Preprocessor defaults to LF line endings. So, I'm guessing the CRLFs are being introduced by an I/O layer.

I don't think this breaks anything: it's just somewhat annoying.
open("Makefile", "w") as opposed to open("Makefile", "wb") somewhere, I guess.
That was actually done on purpose. Why care?
(Reporter)

Comment 3

6 years ago
I've been using git to version control my objdir so I can compare output from the official build system and my hackery. Git whines about CRLF by default, which is annoying.

This is a minor inconvenience. If you want to mark WONTFIX, I'll accept it.
(In reply to Gregory Szorc [:gps] from comment #3)
> I've been using git to version control my objdir so I can compare output
> from the official build system and my hackery. Git whines about CRLF by
> default, which is annoying.

You can configure it not to.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.