346 bytes, text/html
Jeff Hammel: review+
Right now we add Components.stack for both fail and pass states in assertions.js. We should really only do this for test failures. There is no need for pass states. That will drastically limit the amount of data we have to pass through JSBridge.
Created attachment 650359 [details] Pointer to Github pull request: https://github.com/mozilla/mozmill/pull/84 Pointer to Github pull-request
Attachment #650359 - Flags: review?(jhammel)
Comment on attachment 650359 [details] Pointer to Github pull request: https://github.com/mozilla/mozmill/pull/84 Assuming this doesn't break anything, sounds good to me
Attachment #650359 - Flags: review?(jhammel) → review+
Nothing on our side depends on it. Stacks are only useful when you really have a failure. So we will be fine with this patch. Landed as: https://github.com/mozilla/mozmill/commit/aa922595402de0a1b564c05f4448ab66cbec18fb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Just for comparison, the numbers speak themselves: -rw-r--r--@ 1 henrik staff 264310 Aug 9 11:26 new.txt -rw-r--r--@ 1 henrik staff 728381 Aug 9 11:27 old.txt It's a reduction of 64% in size of a report.
You need to log in before you can comment on or make changes to this bug.