Don't silence ImportErrors from the memcache backend

VERIFIED FIXED

Status

Cloud Services
Server: Sync
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: rfkelly, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 650389 [details] [diff] [review]
don't silence ImportErrors related to our own code

The test_memcachedsql.py tests silence any ImportErrors from the memcache backend and related code.  This has caused us to miss several bugs, including another one I just found.  This patch fixes the logic to skip tests if pylibmc cannot be imported, while still reporting ImportErrors related to our own code.
Attachment #650389 - Flags: review?(rmiller)
Attachment #650389 - Flags: review?(rmiller) → review+
Whiteboard: [qa+]
(Assignee)

Comment 1

6 years ago
http://hg.mozilla.org/services/server-storage/rev/440bb15d521a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Verified in code and through functional tests.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.