781504 - patchreader: interdiff failing with "No valid patch files were found in the attachment"

Status: RESOLVED WORKSFORME

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

https://bugzilla.mozilla.org/attachment.cgi?oldid=639974;action=interdiff;newid=650480;headers=1

Use of uninitialized value in hash element
 at Bugzilla/PatchReader/PatchInfoGrabber.pm line 40
 Bugzilla::PatchReader::PatchInfoGrabber::next_section(...) called at Bugzilla/PatchReader/FixPatchRoot.pm line 126
 Bugzilla::PatchReader::FixPatchRoot::next_section(...) called at Bugzilla/PatchReader/Raw.pm line 228
 Bugzilla::PatchReader::Raw::_maybe_end_section(...) called at Bugzilla/PatchReader/Raw.pm line 196
 Bugzilla::PatchReader::Raw::_maybe_end_file(...) called at /data/www/bugzilla.mozilla.org/Bugzilla/PatchReader/Raw.pm line 85
 Bugzilla::PatchReader::Raw::next_line(...) called at Bugzilla/PatchReader/Raw.pm line 263
 Bugzilla::PatchReader::Raw::iterate_string(...) called at Bugzilla/Attachment/PatchReader.pm line 194
 Bugzilla::Attachment::PatchReader::get_unified_diff(...) called at Bugzilla/Attachment/PatchReader.pm line 106
 Bugzilla::Attachment::PatchReader::process_interdiff(...) called at attachment.cgi line 435

Comment 1

[Frédéric Buclin]

It's not only about hg diffs. Same problem with bzr:

https://bugzilla.mozilla.org/attachment.cgi?oldid=629564&action=interdiff&newid=633619&headers=1

Comment 2

[Frédéric Buclin]

Could this bug be fixed asap, please? It's a pain to review large patches when it's impossible to compare a version with a previous one. This forces the reviewer to review the whole patch again.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Do we know which bug has been caused this regression? Should we consider to backout the appropriate patch until this problem is solved? I have to second Frederic's opinion, that this is more than annoying.

Comment 4

[Benjamin Smedberg]

http://benjamin.smedbergs.us/interdiff/ can serve as a workaround.

Comment 5

[:glob ✱]

sorry, i've been unexpectedly afk for a while; i'll look at this as a matter of urgency once i've caught up.

Comment 6

[:glob ✱]

i can't reproduce the error locally using the updated patchreader, nor the original.
i see the warnings, but the diff always works.

the investigation continues..

Comment 7

[:glob ✱]

i can't reproduce this on our pre-production staging environment either, which is concerning.

there are failures on other mozilla hosted environments, but i've traced them down to either interdiff or patch not being installed.

Comment 8

[:glob ✱]

i believe i've found the source of the problem.
the interdiff issues aren't related to this warning, i've created bug 783317 to track.

Comment 9

[:glob ✱]

i can no longer reproduce this issue.