78153 - Find dialog should have XUL dialog access keys

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Andy Grover]

Find dialog should have keyboard accels, and the appropriate letters in the UI
text underlined.

Comment 1

[Andy Grover]

*** Bug 78152 has been marked as a duplicate of this bug. ***

Comment 2

[:deanis74]

Blake, I can take this if you want.  I'm trying to learn at least a little bit 
about XUL, and this seems pretty straight-forward.

Comment 3

[sairuh (rarely reading bugmail)]

confirming and clarifying summary.

Comment 4

[Blake Ross]

Sure, -> Dean. Thanks.  I take it this is just to add accesskeys to the 
checkboxes.  Be advised that even when you add them, they won't work (some 
other bug), and currently they won't even show up (68841).

Comment 5

[Jesse Ruderman]

Accesskeys not working in XUL is bug 959.

Comment 6

[:deanis74]

So Blake, it seems like it isn't even worthwhile to get to this until at least 
bug 68841 is fixed.  Marking dependent on that.

Comment 7

[:deanis74]

I guess I can still attach my patch.  The only access key that shows up right 
now is the one for Find Text.  The checkbox access keys not appearing is bug 
68841.  And none of them work, bug 959.

I used 'c' for Match Case instead of 'm' because 'c' seems to be pretty common 
across apps on my reference platform, Win32.

We should also do the Replace dialog, used by composer.  If someone wants to 
file a bug and assign it to me, I'll get on it someday soon.

Comment 8

[:deanis74]

Attachment: patch

Comment 9

[:deanis74]

->1.0 based on bug 959 and bug 68841.

Comment 10

[Chad Austin]

See bug 959.  The patch contains the start of a fix for this one.

Comment 11

[:deanis74]

Let's keep the patch for this, which is complete in this bug, here instead of
959.  The latest patches to that bug don't have the find dialog changes anymore.

Comment 12

[Chad Austin]

I chose the wrong accesskeys.  mpt, aaronl, someone... wanna decide on what they
should be?

Comment 13

[:deanis74]

So did I, and I left one out.  Looking at a standard Windows find dialog, they 
should be:

Text field:
  Fi_n_d text

Checkboxes:
  Match upper/lower _c_ase
  _W_rap around *
  Search _b_ackwards *

* these two are not in the standard find dialog.  I chose what makes sense to 
me.

Buttons:
  _F_ind
  Cancel  (no access key - Esc)

I'll wait for bug 959 to be fixed, then I'll do up a new patch.

(personally I think "upper/lower" is extraneous in "Match Case" but that's a 
separate issue)

Comment 14

[Matthew T (active 1999-2002)]

The `Find' button shouldn't have an access key, since you can already activate
it with the Enter key. Giving it an access key would slow users down not just in
this dialog, but in every dialog which has a default button.

Comment 15

[:deanis74]

I used the common Find dialog from Windows as my example.  The Find button has F
as an access key.  In Windows, only OK and Cancel do not have access keys.  If
the default button has another word, it has an access key.  As long as Enter
still works on the button, it's not going to slow anyone down if there are two
ways of activating it with the keyboard.

Comment 16

[sairuh (rarely reading bugmail)]

mass moving open bugs pertaining to find in page/frame to [e-mail] as
qa contact.

to find all bugspam pertaining to this, set your search string to
"AppleSpongeCakeWithCaramelFrosting".

Comment 17

[:deanis74]

--> default owner

Comment 18

[Blake Ross]

will worry about this once 959 is fixed.

Comment 19

[:deanis74]

The fix for bug 959 has been checked back in.  Blake, if you want me to do up
the patch assign this over to me.

Comment 20

[Blake Ross]

-> dean

Comment 21

[:deanis74]

Attachment: cvs diff -u /xpfe/components/find/resources

This one adds the access keys I described in comment 13.  Note that the access
keys for the three check boxes don't appear due to bug 68841.  They still work,
though.

Comment 22

[:deanis74]

This should go in for 1.0.

Comment 23

[Blake Ross]

Comment on attachment 72335 [details] [diff] [review]
cvs diff -u /xpfe/components/find/resources

sr=blake

Comment 24

[Aaron Leventhal]

Comment on attachment 72335 [details] [diff] [review]
cvs diff -u /xpfe/components/find/resources

r=aaronl

Comment 25

[Asa Dotzler [:asa]]

Comment on attachment 72335 [details] [diff] [review]
cvs diff -u /xpfe/components/find/resources

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 26

[:deanis74]

fixed on the trunk

Comment 27

[sairuh (rarely reading bugmail)]

vrfy'd fixed on linux rh7.2 and win2k using 2002.03.13.0x comm trunk bits.