Last Comment Bug 781548 - Add WebAPI tests to resume held call (WebTelephony)
: Add WebAPI tests to resume held call (WebTelephony)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla17
Assigned To: Robert Wood [:rwood]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-09 08:42 PDT by Robert Wood [:rwood]
Modified: 2012-08-11 19:55 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (10.16 KB, patch)
2012-08-09 14:55 PDT, Robert Wood [:rwood]
jgriffin: review+
Details | Diff | Review
Updated patch (manifest) (10.62 KB, patch)
2012-08-10 10:58 PDT, Robert Wood [:rwood]
jgriffin: review+
Details | Diff | Review

Description Robert Wood [:rwood] 2012-08-09 08:42:21 PDT
Add two new WebAPI tests for WebTelephony, to test resuming a held call. One test for incoming call and one for outgoing.
Comment 1 Robert Wood [:rwood] 2012-08-09 14:55:26 PDT
Created attachment 650689 [details] [diff] [review]
Patch
Comment 2 Jonathan Griffin (:jgriffin) 2012-08-10 09:59:06 PDT
Comment on attachment 650689 [details] [diff] [review]
Patch

Review of attachment 650689 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!  Can you update this patch to add these tests to http://mxr.mozilla.org/mozilla-central/source/dom/telephony/test/marionette/manifest.ini?  This will allow them to get picked up by the continuous integration server.
Comment 3 Robert Wood [:rwood] 2012-08-10 10:58:06 PDT
Created attachment 650946 [details] [diff] [review]
Updated patch (manifest)
Comment 4 Jonathan Griffin (:jgriffin) 2012-08-10 15:14:21 PDT
Landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/8ed0328cfa9e
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-11 19:55:03 PDT
https://hg.mozilla.org/mozilla-central/rev/8ed0328cfa9e

Note You need to log in before you can comment on or make changes to this bug.