Last Comment Bug 781680 - IonMonkey: Track IonCode in MemoryMetrics
: IonMonkey: Track IonCode in MemoryMetrics
Status: RESOLVED FIXED
[ion:p1]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: general
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: LandIon
  Show dependency treegraph
 
Reported: 2012-08-09 15:46 PDT by Sean Stangl [:sstangl]
Modified: 2012-08-10 11:34 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Backtrace. (10.03 KB, text/plain)
2012-08-09 15:46 PDT, Sean Stangl [:sstangl]
no flags Details
patch (1.47 KB, patch)
2012-08-09 17:53 PDT, Sean Stangl [:sstangl]
dvander: review+
Details | Diff | Splinter Review

Description Sean Stangl [:sstangl] 2012-08-09 15:46:47 PDT
Created attachment 650704 [details]
Backtrace.

Failure in MemoryMetrics.cpp on x86_64 Debug IonMonkey browser. Might involve DOM natives.

Appears to be trivially reproducible by visiting dromaeo.com. It sometimes triggers before you get a chance to hit "Run". Also occasionally reproducible by conducting a Google search.

Built with HG commit 8c33b71cce49 (Thu Aug 09 19:43:47 2012 +0200).

Backtrace attached.
Comment 1 Sean Stangl [:sstangl] 2012-08-09 17:53:05 PDT
Created attachment 650739 [details] [diff] [review]
patch

Fixes the issue without creating an additional tracking kind in cStats. Traking IonCode as part of the Script seems reasonable.

As far as I can tell, this fixes the assertion. I managed to run Dromaeo about halfway (before successfully stopping it) several times, and Google searches didn't assert.
Comment 2 Sean Stangl [:sstangl] 2012-08-10 11:34:44 PDT
http://hg.mozilla.org/projects/ionmonkey/rev/b3ece996df7e

Note You need to log in before you can comment on or make changes to this bug.