IonMonkey: Track IonCode in MemoryMetrics

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sstangl, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ion:p1])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 650704 [details]
Backtrace.

Failure in MemoryMetrics.cpp on x86_64 Debug IonMonkey browser. Might involve DOM natives.

Appears to be trivially reproducible by visiting dromaeo.com. It sometimes triggers before you get a chance to hit "Run". Also occasionally reproducible by conducting a Google search.

Built with HG commit 8c33b71cce49 (Thu Aug 09 19:43:47 2012 +0200).

Backtrace attached.
(Reporter)

Comment 1

5 years ago
Created attachment 650739 [details] [diff] [review]
patch

Fixes the issue without creating an additional tracking kind in cStats. Traking IonCode as part of the Script seems reasonable.

As far as I can tell, this fixes the assertion. I managed to run Dromaeo about halfway (before successfully stopping it) several times, and Google searches didn't assert.
Attachment #650739 - Flags: review?(dvander)
(Reporter)

Updated

5 years ago
Summary: IonMonkey: Assertion Failure: n2 % gc::ArenaSize == 0 in MemoryMetrics.cpp:60 → IonMonkey: Track IonCode in MemoryMetrics
Attachment #650739 - Flags: review?(dvander) → review+
(Reporter)

Comment 2

5 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/b3ece996df7e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.