781697 - Links to /tag/, /feeds/ and /templates list pages are incorrectly given class="new"

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect, P2)

Description

[Trevor]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120713225548

Steps to reproduce:

On this page for example:
https://developer.mozilla.org/en-US/docs/Mozilla/Boot_to_Gecko


Actual results:

The View All... at the bottom of the left column has class="new"


Expected results:

Links to tag list pages should not be given this class.

Comment 1

[Trevor]

Attachment: Patch to ignore speical paths from being marked new

I think this should work. Sorry, I tried to build a local test machine and to figure out github, no luck.

Comment 2

[John Karahalis [:openjck]]

Thanks Trevor! Really great work.

I will ping our developers about this. If you want to learn more about Git, try:
http://try.github.com/levels/1/challenges/1

David: Can you confirm that this patch does this trick, and merge it in if it does?

Comment 3

[Nickolay_Ponomarev]

Comment on attachment 653404 [details] [diff] [review]
Patch to ignore speical paths from being marked new

Seems like this fell through the cracks.

Comment 4

[Les Orchard [:lorchard]]

Taking a look... This needs some tests, and then needs to be submitted as a pull request for review & merge. I might take a shot at that

Comment 5

[Les Orchard [:lorchard]]

https://github.com/mozilla/kuma/pull/723

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f0caf6e30911c6b6987f2d83e6d75b9c54dfe93c
bug 781697: Exclude special paths in docs URL space from "new" link annotation

https://github.com/mozilla/kuma/commit/a220d2faec4fc98c135cdc3ba2da65da4fa11be7
Merge pull request #723 from lmorchard/781697-incorrect-new-class-on-links

bug 781697: Exclude special paths in docs URL space from "new" link annotation

Comment 7

[Les Orchard [:lorchard]]

Comment on attachment 653404 [details] [diff] [review]
Patch to ignore speical paths from being marked new

Ended up reworking this patch in PR 723