Closed
Bug 781745
Opened 12 years ago
Closed 12 years ago
Intermittent testBookmarksTab | Context menu has New Tab option - Open in New Tab
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 19
People
(Reporter: philor, Assigned: gbrown)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
7.52 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=14284004&tree=Mozilla-Inbound Android Tegra 250 mozilla-inbound opt test robocop on 2012-08-09 22:27:53 PDT for push 8405e424a351 slave: tegra-078 48 INFO TEST-UNEXPECTED-FAIL | testBookmarksTab | Context menu has New Tab option - Open in New Tab Exception caught during test! junit.framework.AssertionFailedError: 48 INFO TEST-UNEXPECTED-FAIL | testBookmarksTab | Context menu has New Tab option - Open in New Tab at junit.framework.Assert.fail(Assert.java:47) at org.mozilla.fennec.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:107) at org.mozilla.fennec.FennecMochitestAssert.ok(FennecMochitestAssert.java:136) at org.mozilla.fennec.tests.testBookmarksTab.testContextMenu(testBookmarksTab.java:124) at org.mozilla.fennec.tests.testBookmarksTab.testBookmarksTab(testBookmarksTab.java:51) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:521) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186) at org.mozilla.fennec.tests.BaseTest.runTest(BaseTest.java:94) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1447) 49 INFO TEST-UNEXPECTED-FAIL | testBookmarksTab | Exception caught - junit.framework.AssertionFailedError: 48 INFO TEST-UNEXPECTED-FAIL | testBookmarksTab | Context menu has New Tab option - Open in New Tab
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → gbrown
Assignee | ||
Comment 7•12 years ago
|
||
I do not know with certainty what is causing this intermittent failure. However, we had similar problems in testHistoryTab before we "hardened" that test. This patch makes testBookmarksTab more like testHistoryTab, in particular trying to wait for list population before proceeding with the test. (Patch also includes clean-up of some obvious copy/paste errors.)
Attachment #676187 -
Flags: review?(jmaher)
Comment 8•12 years ago
|
||
Comment on attachment 676187 [details] [diff] [review] wait for list population before testing contents Review of attachment 676187 [details] [diff] [review]: ----------------------------------------------------------------- quite a big change, I don't see any red flags here.
Attachment #676187 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5396fe844e35
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5396fe844e35
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•