Last Comment Bug 781771 - DESCRIPTION of ALARM component resets to "Mozilla Standardbeschreibung" in Lightning via CalDAV
: DESCRIPTION of ALARM component resets to "Mozilla Standardbeschreibung" in Li...
Product: Calendar
Classification: Client Software
Component: Provider: CalDAV (show other bugs)
: Lightning 1.6
: All All
-- normal (vote)
: 1.9
Assigned To: Philipp Kewisch [:Fallen]
Depends on:
  Show dependency treegraph
Reported: 2012-08-10 04:22 PDT by david.binkovic
Modified: 2012-08-20 13:13 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Fix - v1 (1.07 KB, patch)
2012-08-15 06:00 PDT, Philipp Kewisch [:Fallen]
matthew.mecca: review+
Details | Diff | Splinter Review

Description User image david.binkovic 2012-08-10 04:22:59 PDT
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.60 Safari/537.1

Steps to reproduce:

Receive an appointment with e.g. the following ALARM component:

DESCRIPTION:My description

Open the appointment details window, close the dialog again by clicking the "X" icon

Actual results:

- Confirmation window asking if changes should be saved
- ALARM gets changed to 

DESCRIPTION:Mozilla Standardbeschreibung

Expected results:

- No confirmation window, since nothing was changed
- No change of the ALARM DESCRIPTION
Comment 1 User image david.binkovic 2012-08-10 04:24:13 PDT
Note: It works (i.e. no confirmation popup, no changes made) when the appointment's ALARM already contains a description "Mozilla Standardbeschreibung" when initially being received by Lightning.
Comment 2 User image Philipp Kewisch [:Fallen] 2012-08-15 06:00:18 PDT
Created attachment 652082 [details] [diff] [review]
Fix - v1
Comment 3 User image Wolfgang Rosenauer [:wolfiR] 2012-08-17 00:21:22 PDT
I've modified my 1.7b3 Lightning with these changes but at least after opening an appointment and closing it it still asks if I want to save my changes while I haven't done any.
But at least the event as sent back to the caldav server has the original description for the alarm AFAICS. Just the dialog still thinks something changed.
Comment 4 User image Philipp Kewisch [:Fallen] 2012-08-17 04:20:42 PDT
Yeah, there is another bug open on that. Some X-Prop is being set, related to notifications.
Comment 5 User image Matthew Mecca [:mmecca] 2012-08-19 20:29:46 PDT
Comment on attachment 652082 [details] [diff] [review]
Fix - v1

Looks good. r=mmecca
Comment 6 User image Philipp Kewisch [:Fallen] 2012-08-20 13:13:24 PDT
Pushed to comm-central changeset c4c12e6a975a

Note You need to log in before you can comment on or make changes to this bug.