781771 - DESCRIPTION of ALARM component resets to "Mozilla Standardbeschreibung" in Lightning via CalDAV

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[david.binkovic]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.60 Safari/537.1

Steps to reproduce:

Receive an appointment with e.g. the following ALARM component:

BEGIN:VALARM
TRIGGER;VALUE=DURATION:-PT15M
ACTION:DISPLAY
DESCRIPTION:My description
END:VALARM

Open the appointment details window, close the dialog again by clicking the "X" icon


Actual results:

- Confirmation window asking if changes should be saved
- ALARM gets changed to 


BEGIN:VALARM
TRIGGER;VALUE=DURATION:-PT15M
ACTION:DISPLAY
DESCRIPTION:Mozilla Standardbeschreibung
END:VALARM



Expected results:

- No confirmation window, since nothing was changed
- No change of the ALARM DESCRIPTION

Comment 1

[david.binkovic]

Note: It works (i.e. no confirmation popup, no changes made) when the appointment's ALARM already contains a description "Mozilla Standardbeschreibung" when initially being received by Lightning.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

I've modified my 1.7b3 Lightning with these changes but at least after opening an appointment and closing it it still asks if I want to save my changes while I haven't done any.
But at least the event as sent back to the caldav server has the original description for the alarm AFAICS. Just the dialog still thinks something changed.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yeah, there is another bug open on that. Some X-Prop is being set, related to notifications.

Comment 5

[Matthew Mecca [:mmecca]]

Comment on attachment 652082 [details] [diff] [review]
Fix - v1

Looks good. r=mmecca

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset c4c12e6a975a