Closed Bug 781772 Opened 10 years ago Closed 10 years ago

Accesskey for Inspect entry in Tools > Web Developer popup menu should be "I"

Categories

(DevTools :: Inspector, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 18

People

(Reporter: Optimizer, Assigned: Optimizer)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

"I" is free, and it would make more sense to have the first alphabet as accesskey, rather than the last.

If any specific reason is there, feel free to close the bug.

It would also leave free "T" to be the accesskey for "Timeline"
This is why: https://bugzilla.mozilla.org/show_bug.cgi?id=565872#c9

And afaik, it's not valid anymore.
OS: Windows 7 → All
Hardware: x86_64 → All
Then we should go ahead and do this. It would be small change. I will try to create the patch, but I will have to setup the repo and all the tools first.
OS: All → Windows 7
Hardware: All → x86_64
I am taking it, the patch is very small, does it require any ui0review or something like that ?
I really want the "t" accesskey :P
Assignee: nobody → scrapmachines
Status: NEW → ASSIGNED
Attached patch patch v0.0Splinter Review
Changing the T to I
Attachment #659847 - Flags: review?(paul)
Comment on attachment 659847 [details] [diff] [review]
patch v0.0

I can't review that (I'm not a browser peer).

We usually also change the property name when we change the value. But in this case, I'm not sure if it's really needed.
Attachment #659847 - Flags: review?(paul) → review?(dao)
Comment on attachment 659847 [details] [diff] [review]
patch v0.0

I also just noticed that Debugger has no access key...
Attachment #659847 - Flags: review?(dao) → review+
Right now, pressing 'd' works as 'd' is free and Debugger starts with 'd'.
Do you want it as this bug's scope ?
(In reply to Girish Sharma [:Optimizer] from comment #7)
> Right now, pressing 'd' works as 'd' is free and Debugger starts with 'd'.

This works because it happens that no other menu item has occupied D. We should explicitly reserve D for Debugger such that it will also be underlined.

> Do you want it as this bug's scope ?

No, this would be a separate bug.
ok filed bug 790227 for that.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/f96be72187c0
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f96be72187c0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.