781772 - Accesskey for Inspect entry in Tools > Web Developer popup menu should be "I"

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Girish Sharma [:Optimizer]]

"I" is free, and it would make more sense to have the first alphabet as accesskey, rather than the last.

If any specific reason is there, feel free to close the bug.

It would also leave free "T" to be the accesskey for "Timeline"

Comment 1

[Paul Rouget [:paul]]

This is why: https://bugzilla.mozilla.org/show_bug.cgi?id=565872#c9

And afaik, it's not valid anymore.

Comment 2

[Girish Sharma [:Optimizer]]

Then we should go ahead and do this. It would be small change. I will try to create the patch, but I will have to setup the repo and all the tools first.

Comment 3

[Girish Sharma [:Optimizer]]

I am taking it, the patch is very small, does it require any ui0review or something like that ?
I really want the "t" accesskey :P

Comment 4

[Girish Sharma [:Optimizer]]

Attachment: patch v0.0

Changing the T to I

Comment 5

[Paul Rouget [:paul]]

Comment on attachment 659847 [details] [diff] [review]
patch v0.0

I can't review that (I'm not a browser peer).

We usually also change the property name when we change the value. But in this case, I'm not sure if it's really needed.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 659847 [details] [diff] [review]
patch v0.0

I also just noticed that Debugger has no access key...

Comment 7

[Girish Sharma [:Optimizer]]

Right now, pressing 'd' works as 'd' is free and Debugger starts with 'd'.
Do you want it as this bug's scope ?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Girish Sharma [:Optimizer] from comment #7)
> Right now, pressing 'd' works as 'd' is free and Debugger starts with 'd'.

This works because it happens that no other menu item has occupied D. We should explicitly reserve D for Debugger such that it will also be underlined.

> Do you want it as this bug's scope ?

No, this would be a separate bug.

Comment 9

[Girish Sharma [:Optimizer]]

ok filed bug 790227 for that.

Comment 10

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/f96be72187c0

Comment 11

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/f96be72187c0