781782 - contentType parameter of Blob slice should be converted to lower case

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Saurabh Anand [:sawrubh]]

Attachment: Test Case

All the upper case characters in contentType parameter of slice method on Blob objects should be converted to lower case, according to Section 4.B.b of http://dev.w3.org/2006/webapi/FileAPI/#slide-method-algo .

Expected Result : All upper case characters in contentType parameter should be converted to lower case
Actual Result : Upper case remains unchanged

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Lowercase the content type in the Blob and File constructors and Blob.slice

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Lowercase the content type in the Blob and File constructors and Blob.slice

Comment 3

[Boris Zbarsky [:bzbarsky]]

Andrea, sorry for the extra review; the only difference is more fail annotations removed from web platform tests...

But actually, there are more failures.  I guess I get to do more try runs.  ;)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Lowercase the content type in the Blob and File constructors and Blob.slice

Ben, could you review the fetch changes please?  The service-workers/service-worker/invalid-blobtype.https.html web platform test used to pass because we left the null char in the type, so trying to set the header failed.  But with Blob fixed to use an empty type string in this case it started failing (but only in e10s for some reason???), because we were not properly implementing the extract operation from fetch in the Blob case.

I have no idea why that failure was e10s-only and would love to hear if you have some idea why....

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8814014 [details] [diff] [review]
Lowercase the content type in the Blob and File constructors and Blob.slice

Bah, there are more fetch bits that need adjusting. Let's do this properly....

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Fix fetch code to not set a Content-Type header when it shouldn't

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Lowercase the content type in the Blob and File constructors and Blob.slice

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60d9b4f50544
part 1.  Fix fetch code to not set a Content-Type header when it shouldn't.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/9acaf2d4db15
part 2.  Lowercase the content type in the Blob and File constructors and Blob.slice.  r=baku

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60d9b4f50544
https://hg.mozilla.org/mozilla-central/rev/9acaf2d4db15