Closed Bug 781831 Opened 7 years ago Closed 7 years ago

Build media plugins and omx plugin by default on Android to get libstagefright video decoding support

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 17
Tracking Status
firefox18 --- verified

People

(Reporter: cajbir, Assigned: cajbir)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 759945 landed the software video decoding support using libstagefright for android pref'd off. It was also disabled by default at compile time for Android. This should be enabled by default using the following configure options for Android only:

--enable-media-plugins
--enable-omx-plugin
Depends on: 759945
Component: Video/Audio → General
Product: Core → Firefox for Android
Enable building of media and omx plugins by default on Android. They are still disabled by a pref at runtime.
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
Attachment #651564 - Flags: review?(khuey)
Comment on attachment 651564 [details] [diff] [review]
Build media plugins by default on android

Patch breaks XUL android builds. Will fix and update.
Attachment #651564 - Flags: review?(khuey)
Comment on attachment 651564 [details] [diff] [review]
Build media plugins by default on android

Build issue on XUL android not related to this patch - re-enabling review request.
Attachment #651564 - Flags: review?(khuey)
'make package' gives an error trying to move the libomxplugin.so file due to it being missing from the manifest on XUL android.
Attachment #651616 - Flags: review?(mark.finkle)
Comment on attachment 651616 [details] [diff] [review]
Fix for package error on XUL android

Sorry. I should have caught this.
Attachment #651616 - Flags: review?(mark.finkle) → review+
For the benefit of people flocking to this bug after Adobe stopped Flash installing on mobile, the about:config pref to switch to true is named:

media.plugins.enabled
Comment on attachment 651564 [details] [diff] [review]
Build media plugins by default on android

Review of attachment 651564 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't let you disable these flags on Android.
Attachment #651564 - Flags: review?(khuey) → review-
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #7)
> 
> This doesn't let you disable these flags on Android.

Feedback from the android people needed here. Should I just remove the default enable from configure.in and we add the enable flags to the files in mobile/android/config/mozconfig?

If not, what combination of configure options would be best for enabling on android but not on desktop but allowing disabling of it?
(In reply to Chris Double (:doublec) from comment #8)
> (In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #7)
> > 
> > This doesn't let you disable these flags on Android.
> 
> Feedback from the android people needed here. Should I just remove the
> default enable from configure.in and we add the enable flags to the files in
> mobile/android/config/mozconfig?

We'd rather not have non-default flags added to the in-tree mozconfigs.  As much as possible, the default configuration for developers should match the configuration used for official builds.

I think if you just place each "Enable support on android by default" *above* the corresponding MOZ_ARG_ENABLE_BOOL (instead of below it) then it will take effect by default but still allow disabling.
(In reply to Matt Brubeck (:mbrubeck) from comment #9)
> I think if you just place each "Enable support on android by default"
> *above* the corresponding MOZ_ARG_ENABLE_BOOL (instead of below it) then it
> will take effect by default but still allow disabling.

Right.
Address review comment. Fix is as per recommended change in comments.
Attachment #651564 - Attachment is obsolete: true
Attachment #652307 - Flags: review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/62786c75d7cd
https://hg.mozilla.org/mozilla-central/rev/c676b554c7bb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Changes were applied on the latest Nightly. Closing bug as verified fixed.

--
Firefox 18.0a1 (2012-09-19)
Device: Galaxy Note
OS: Android 4.0.4
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.