781831 - Build media plugins and omx plugin by default on Android to get libstagefright video decoding support

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[cajbir (:cajbir)]

Bug 759945 landed the software video decoding support using libstagefright for android pref'd off. It was also disabled by default at compile time for Android. This should be enabled by default using the following configure options for Android only:

--enable-media-plugins
--enable-omx-plugin

Comment 1

[cajbir (:cajbir)]

Attachment: Build media plugins by default on android

Enable building of media and omx plugins by default on Android. They are still disabled by a pref at runtime.

Comment 2

[cajbir (:cajbir)]

Comment on attachment 651564 [details] [diff] [review]
Build media plugins by default on android

Patch breaks XUL android builds. Will fix and update.

Comment 3

[cajbir (:cajbir)]

Comment on attachment 651564 [details] [diff] [review]
Build media plugins by default on android

Build issue on XUL android not related to this patch - re-enabling review request.

Comment 4

[cajbir (:cajbir)]

Attachment: Fix for package error on XUL android

'make package' gives an error trying to move the libomxplugin.so file due to it being missing from the manifest on XUL android.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 651616 [details] [diff] [review]
Fix for package error on XUL android

Sorry. I should have caught this.

Comment 6

[Mardeg]

For the benefit of people flocking to this bug after Adobe stopped Flash installing on mobile, the about:config pref to switch to true is named:

media.plugins.enabled

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 651564 [details] [diff] [review]
Build media plugins by default on android

Review of attachment 651564 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't let you disable these flags on Android.

Comment 8

[cajbir (:cajbir)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #7)
> 
> This doesn't let you disable these flags on Android.

Feedback from the android people needed here. Should I just remove the default enable from configure.in and we add the enable flags to the files in mobile/android/config/mozconfig?

If not, what combination of configure options would be best for enabling on android but not on desktop but allowing disabling of it?

Comment 9

[Matt Brubeck (:mbrubeck)]

(In reply to Chris Double (:doublec) from comment #8)
> (In reply to Kyle Huey [:khuey] ([e-mail]) from comment #7)
> > 
> > This doesn't let you disable these flags on Android.
> 
> Feedback from the android people needed here. Should I just remove the
> default enable from configure.in and we add the enable flags to the files in
> mobile/android/config/mozconfig?

We'd rather not have non-default flags added to the in-tree mozconfigs.  As much as possible, the default configuration for developers should match the configuration used for official builds.

I think if you just place each "Enable support on android by default" *above* the corresponding MOZ_ARG_ENABLE_BOOL (instead of below it) then it will take effect by default but still allow disabling.

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Matt Brubeck (:mbrubeck) from comment #9)
> I think if you just place each "Enable support on android by default"
> *above* the corresponding MOZ_ARG_ENABLE_BOOL (instead of below it) then it
> will take effect by default but still allow disabling.

Right.

Comment 11

[cajbir (:cajbir)]

Attachment: Build media plugins by default on android

Address review comment. Fix is as per recommended change in comments.

Comment 12

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62786c75d7cd
https://hg.mozilla.org/integration/mozilla-inbound/rev/c676b554c7bb

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/62786c75d7cd
https://hg.mozilla.org/mozilla-central/rev/c676b554c7bb

Comment 14

[Cristian Nicolae (:xti)]

Changes were applied on the latest Nightly. Closing bug as verified fixed.

--
Firefox 18.0a1 (2012-09-19)
Device: Galaxy Note
OS: Android 4.0.4