781852 - Remove getTitle from Tab

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch

Tabs has a getTitle method. margaret noticed that we never use because they also have a getDisplayTitle method that's better (returns the url if there is no page title). In fact, its caused crashes for me when I tried to use it on accident for launcher shortcuts. Probably better not to keep around if we don't need it.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

So we don't want a way to get the <title> of a document, if one is given?

Comment 2

[:Margaret Leibovic]

Comment on attachment 650920 [details] [diff] [review]
Patch

I thought we already removed this at one point, and I added it back in bug 730039. Anyway, we need it for insertLocalTabs in TabsAccessor, so we can't take this patch.

Looking at m-c, I think this patch did already land at one point anyway; look at addBookmark:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/Tab.java#389

Comment 3

[Owais Kazi]

Is this bug still active?

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.