Closed Bug 781866 Opened 10 years ago Closed 10 years ago

Clear up and simplify some names in localStorage code

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: sicking, Assigned: sicking)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch Patch to fix (obsolete) — Splinter Review
Assignee: nobody → jonas
Attachment #650950 - Flags: review?
Comment on attachment 650950 [details] [diff] [review]
Patch to fix

Honza, if you don't have time, let me know if you're ok with the general change and I can ask someone else to review. Or we can wait until you get back.
Attachment #650950 - Flags: review? → review?(honzab.moz)
Attached patch Patch to fix (obsolete) — Splinter Review
Previous version was busted, this one should work.
Attachment #650950 - Attachment is obsolete: true
Attachment #650950 - Flags: review?(honzab.moz)
Attachment #651094 - Flags: review?(honzab.moz)
Comment on attachment 651094 [details] [diff] [review]
Patch to fix

Review of attachment 651094 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

::: dom/src/storage/nsDOMStorage.cpp
@@ +301,5 @@
>                     aceDomain);
>      }
>  
>      nsCAutoString key;
> +    rv = nsDOMStorageDBWrapper::CreateReversedDomain(aceDomain, key);

Hmm... the original name better described the purpose.  Also, it is not just reversed domain actually.  But up to you.  Both ways are good probably.
Attachment #651094 - Flags: review?(honzab.moz) → review+
Attached patch Updated to tipSplinter Review
Forwarding review flag
Attachment #651094 - Attachment is obsolete: true
Attachment #659091 - Flags: review+
Oh, the patch here apply on top of the patch in bug 776416
https://hg.mozilla.org/mozilla-central/rev/bef84aa5ce69
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.