781866 - Clear up and simplify some names in localStorage code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 650950 [details] [diff] [review]
Patch to fix

Honza, if you don't have time, let me know if you're ok with the general change and I can ask someone else to review. Or we can wait until you get back.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Previous version was busted, this one should work.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 651094 [details] [diff] [review]
Patch to fix

Review of attachment 651094 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

::: dom/src/storage/nsDOMStorage.cpp
@@ +301,5 @@
>                     aceDomain);
>      }
>  
>      nsCAutoString key;
> +    rv = nsDOMStorageDBWrapper::CreateReversedDomain(aceDomain, key);

Hmm... the original name better described the purpose.  Also, it is not just reversed domain actually.  But up to you.  Both ways are good probably.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Updated to tip

Forwarding review flag

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Oh, the patch here apply on top of the patch in bug 776416

Comment 7

[Jan Varga [:janv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bef84aa5ce69

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bef84aa5ce69