[MOBETA] By Build Date link should not show for "release" versions

VERIFIED FIXED in 18

Status

Socorro
Webapp
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: adrian, Assigned: espressive)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobeta])

(Reporter)

Description

5 years ago
Currently, on https://crash-stats-dev.allizom.org/topcrasher/byversion/Firefox/14.0.1/14 you can find the option of viewing this report by build date. That option should not be available as Firefox 14.0.1 is on the release channel. 

There is a new field called 'has_build' returned by the /products service that gives you the information you need (true if you can browse by build date, false if not).
It's important to use the "has_build" field and not go by channel, since for betas, we'll have by-build if it's a rapid beta, and not otherwise.

Updated

5 years ago
Whiteboard: [mobeta]
(Assignee)

Comment 2

5 years ago
Pull request sent: https://github.com/mozilla/socorro/pull/799

TEST CASE
---------

When accessing the top crashers page either by version or by OS for a version that is not a rapid beta release, only the 'By Crash Date' link should be visible.
Correction to test case:

When accessing the top crashers page either by version or by OS for a version that is not a nightly, aurora, or rapid beta release, only the 'By Crash Date' link should be visible.

Comment 4

5 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f7a61485fec077bb799fbada8b0d21c82f16082c
only showing by build date for versions where has_build is true fixes bug 781872

https://github.com/mozilla/socorro/commit/23900f51e29d60944ac040aecb84bba7c217103d
Merge pull request #799 from ossreleasefeed/dont-show-bybuilddate-for-release-versions-781872

only showing by build date for versions where has_build is true fixes bug 781872

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
QA verified on dev - When accessing the top crashers page either by version or by OS for a version that is not a nightly, aurora, or rapid beta release, only the 'By Crash Date' link should be visible.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.