781946 - Clean up notifications

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Gregory Szorc [:gps]]

Attachment: Clean up notifications, v1

As part of going through service.js, I cleaned up a bunch of notifications code.

The following notifications were removed because they are unused:

  service:verify-login
  service:changepwd
  service:wipe-server
  service:reset-service
  service:wipe-client
  service:reset-client

I also changed service:changepph to service:change-passphrase

This eliminates a whole lot of Utils.notify() usage and makes the code cleaner. If we need these notifications in the future, they are easy enough to add back in.

Comment 1

[Richard Newman [:rnewman]]

Comment on attachment 651011 [details] [diff] [review]
Clean up notifications, v1

Review of attachment 651011 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, modulo now not catching. Please fix and land, or let's discuss in the bug.

::: services/sync/modules/service.js
@@ -800,4 @@
>    },
>  
>    changePassphrase: function changePassphrase(newphrase) {
> -    return this._catch(this._notify("changepph", "", function onNotify() {

You killed this._catch here. I'm pretty sure we want to catch.

@@ -1622,5 @@
>     * @param engines [optional]
>     *        Array of engine names to reset. If not given, all engines are used.
>     */
> -  resetClient: function resetClient(engines)
> -    this._catch(this._notify("reset-client", "", function onNotify() {

Same…

Comment 2

[Gregory Szorc [:gps]]

https://hg.mozilla.org/services/services-central/rev/7a7aff2f35d3

With this._catch added back in.

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/7a7aff2f35d3