78195 - Frequent crashes when deleting email with M091 [@ nsImapMockChannel::SetupPartExtractorListener]

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[Bob Lord]

This problem has been bothering me for some time, though right now I'm using the
2001-04-27-04 builds.

Several times per day my client will crash when I'm deleting an email.  The
problem does not seem to stem from any particular email, though some times of
emails seem to help trigger the problem.

For example, I'm on the Red Herring daily newsletter mailing list.  When I get
that email, I read it, and then hit delete.  A very large percentage of the
time, when I hit delete, the client will crash.  If I restart, re-read the
email, and then hit delete, the client does *not* crash.  The percentage of
times when I crash on simple text emails is very low in comparison.  So it may
have something to do with the HTML or JS on those rich emails.  But I can't be sure.

FYI: I use IMAP.

Talkback seems to work and should be sending back information.  My email address
is [e-mail] and on two occasions recently I added a short description
that says something like "deleting IMAP email".

Comment 1

[Matthias Versen [:Matti]]

Reporter: Can you poste the talkback ID# ?
(search talkback.exe in mozilla/bin..... and open it.)

Comment 2

[Bob Lord]

here's one:
TB29779077W

Thanks for the info on how to find these bugs!

Comment 3

[esther]

Changing QA contact to karen- imap deleting bug

Comment 4

[scottputterman]

Below is your stack.  It looks like it's going through plugin code.  I wonder if
the next message after a delete (the one it tries to load next) requires a
plugin and we are crashing in it.  If this happens to you, I'd be curious if
there's anything special about the next message.

nsImapMockChannel::SetupPartExtractorListener
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapProtocol.cpp, line 7153] 
nsImapMockChannel::AsyncOpen
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapProtocol.cpp, line 7133] 
NS_OpenURI [..\..\..\dist\include\nsNetUtil.h, line 178] 
nsPluginHostImpl::NewEmbededPluginStream
[d:\builds\seamonkey\mozilla\modules\plugin\nglsrc\nsPluginHostImpl.cpp, line 4300] 
nsPluginHostImpl::InstantiateEmbededPlugin
[d:\builds\seamonkey\mozilla\modules\plugin\nglsrc\nsPluginHostImpl.cpp, line 2603] 
nsObjectFrame::InstantiatePlugin
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsObjectFrame.cpp, line 1063] 
nsObjectFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsObjectFrame.cpp, line 934] 
nsLineLayout::ReflowFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp, line 956] 
nsInlineFrame::ReflowInlineFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp, line 619] 
nsInlineFrame::ReflowFrames
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp, line 428] 
nsInlineFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsInlineFrame.cpp, line 344] 
nsLineLayout::ReflowFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp, line 956] 
nsBlockFrame::ReflowInlineFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 4444] 
nsBlockFrame::DoReflowInlineFrames
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 4328] 
nsBlockFrame::DoReflowInlineFramesAuto
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 4253] 
nsBlockFrame::ReflowInlineFrames
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 4199] 
nsBlockFrame::ReflowLine
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 3332] 
nsBlockFrame::ReflowDirtyLines
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 3021] 
nsBlockFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 1772] 

Comment 5

[scottputterman]

reassigning to mscott.

In bug 82972, jpatel writes:

"Although this crash might have been fixed (referring to 82972), Talkback is
showing that [e-mail] crashed a few times verifying this fix.  The new
crash is already reported in bug 78195, and it seems to be in
nsImapMockChannel::SetupPartExtractorListener.  Just wanted to let you know, so
that you might be able to look into the new crash."

So perhaps we can reproduce this with the shockwave email in 82972.

Comment 6

[Jay Patel [:jay]]

Adding topcrash keyword and [@ nsImapMockChannel::SetupPartExtractorListener] to
the summary for tracking, since this might be a potential topcrash. 

Here is the Talkback info on this crash:

nsImapMockChannel::SetupPartExtractorListener   5 
     First BBID :31369917
     Last BBID  :31372325
     Min Runtime :66
     Max Runtime :626
     First Appearance Date : 2001-06-05
     Last Appearance Date : 2001-06-05
     First BuildID : 2001060411
     Last BuildID : 2001060411

Stack Trace: 

	 nsImapMockChannel::SetupPartExtractorListener
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapProtocol.cpp  line 7194]
	 nsImapMockChannel::AsyncOpen
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapProtocol.cpp  line 7171]
	 NS_OpenURI
[..\..\..\dist\include\nsNetUtil.h  line 181]
	 nsPluginHostImpl::NewEmbededPluginStream
[d:\builds\seamonkey\mozilla\modules\plugin\nglsrc\nsPluginHostImpl.cpp  line 4507]
	 nsPluginHostImpl::InstantiateEmbededPlugin
[d:\builds\seamonkey\mozilla\modules\plugin\nglsrc\nsPluginHostImpl.cpp  line 2770]
	 nsObjectFrame::InstantiatePlugin
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsObjectFrame.cpp  line 1047]
	 nsObjectFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsObjectFrame.cpp  line 893]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsObjectFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsObjectFrame.cpp  line 922]
	 nsLineLayout::ReflowFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineLayout.cpp  line 956]
	 nsBlockFrame::ReflowInlineFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 3460]
	 nsBlockFrame::DoReflowInlineFrames
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 3344]
	 nsBlockFrame::DoReflowInlineFramesAuto
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 3269]
	 nsBlockFrame::ReflowInlineFrames
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 3215]
	 nsBlockFrame::ReflowLine
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2337]
	 nsBlockFrame::ReflowDirtyLines
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2027]
	 nsBlockFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 795]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableCellFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableCellFrame.cpp  line 813]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableRowFrame::ReflowChildren
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp  line 888]
	 nsTableRowFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp  line 1249]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableRowGroupFrame::ReflowChildren
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp 
line 378]
	 nsTableRowGroupFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp 
line 1047]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableFrame::ReflowChildren
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp  line 2945]
	 nsTableFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp  line 1807]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableOuterFrame::OuterReflowChild
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp  line 986]
	 nsTableOuterFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp  line 1530]
	 nsBlockReflowContext::DoReflowBlock
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp  line
573]
	 nsBlockReflowContext::ReflowBlock
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp  line
343]
	 nsBlockFrame::ReflowBlockFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2960]
	 nsBlockFrame::ReflowLine
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2223]
	 nsBlockFrame::ReflowDirtyLines
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2027]
	 nsBlockFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 795]
	 nsBlockReflowContext::DoReflowBlock
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp  line
573]
	 nsBlockReflowContext::ReflowBlock
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp  line
343]
	 nsBlockFrame::ReflowBlockFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2960]
	 nsBlockFrame::ReflowLine
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2223]
	 nsBlockFrame::ReflowDirtyLines
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2027]
	 nsBlockFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 795]
	 nsBlockReflowContext::DoReflowBlock
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp  line
573]
	 nsBlockReflowContext::ReflowBlock
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp  line
343]
	 nsBlockFrame::ReflowBlockFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2960]
	 nsBlockFrame::ReflowLine
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2223]
	 nsBlockFrame::ReflowDirtyLines
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 2027]
	 nsBlockFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 795]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableCellFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableCellFrame.cpp  line 813]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableRowFrame::ReflowChildren
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp  line 888]
	 nsTableRowFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowFrame.cpp  line 1249]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableRowGroupFrame::ReflowChildren
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp 
line 378]
	 nsTableRowGroupFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableRowGroupFrame.cpp 
line 1047]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableFrame::ReflowChildren
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp  line 2945]
	 nsTableFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableFrame.cpp  line 1807]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 745]
	 nsTableOuterFrame::OuterReflowChild
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp  line 986]
	 nsTableOuterFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\table\src\nsTableOuterFrame.cpp  line 1530]
	 nsBlockReflowContext::DoReflowBlock
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowContext.cpp  line
573]
 
 	Source File :
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/imap/src/nsImapProtocol.cpp
line : 7194
     (31372325)	Comments: crash again on 06-04-11-0.9.1 build....for bugzilla 82972
     (31370897)	Comments: crash again when I verifying bug 82972...
     (31370397)	Comments: crash again for bugzilla 82972
     (31370304)	Comments: crash for bug 82972 again
     (31369917)	Comments: crash on 060411-0.9.1 build again for bugzilla 82972

huang, are you able to reproduce this with the latest Trunk builds or the M091
candidate builds?

Comment 7

[(not reading, please use [e-mail] instead)]

really re-assigning to mscott

Comment 8

[scottputterman]

adding PDT+

Comment 9

[Scott MacGregor]

I can't seem to reproduce this crash on the tip. I wonder if it was branch only.
It has to do with messages that require a plugin. 

Comment 10

[Scott MacGregor]

Attachment: proposed fix

Comment 11

[Scott MacGregor]

Here's a hokey little fix that fixes the crash. The problem is with messages
that require plugins to render. The plugin manager is asking us to open the same
nsIImapUrl object twice. The second time, we no longer have a mock channel to
run the url in. this hack simple re-initialzes the url with a new mock channel
the 2nd time we try to open the url. 

Comment 12

[David :Bienvenu]

r/sr = bienvenu

Comment 13

[Navin Gupta]

r=naving

Comment 14

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 15

[Scott MacGregor]

fix checked in. 

Comment 16

[Karen Huang]

Verified on windows 06-22-11-trunk build
There is no crashes anymore by testing with the shockwave email from bug 82972.
but now we display nothing in the message pane for this message (rest issue see 
bug 83500. Marking as verified for this bug now!