The default bug view has changed. See this FAQ.

Add optional pressure and source parameters to nsIDOMWindowUtils's sendMouse methods

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Events
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
mozilla17
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We need a bit more detail in these calls in our metro work.
(Assignee)

Comment 1

5 years ago
Created attachment 651040 [details] [diff] [review]
patch
Assignee: nobody → jmathies
(Assignee)

Comment 2

5 years ago
Comment on attachment 651040 [details] [diff] [review]
patch

This is for event work in metro, we need to be able to synthesize mouse events from content using touch input vs mouse. I added pressure for completeness.

The defaults in the gui event are zero for pressure and mouse for input so the default values here mirror that.
Attachment #651040 - Flags: review?(roc)
Comment on attachment 651040 [details] [diff] [review]
patch

Review of attachment 651040 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me but really needs review from Olli.
Attachment #651040 - Flags: review?(roc)
Attachment #651040 - Flags: review?(bugs)
Attachment #651040 - Flags: review+
Comment on attachment 651040 [details] [diff] [review]
patch


>+  if (aInputSourceArg == nsIDOMMouseEvent::MOZ_SOURCE_UNKNOWN)
>+    aInputSourceArg = nsIDOMMouseEvent::MOZ_SOURCE_MOUSE;
if (expr) {
  stmt;
}


>   void sendMouseEvent(in AString aType,
>                       in float aX,
>                       in float aY,
>                       in long aButton,
>                       in long aClickCount,
>                       in long aModifiers,
>-                      [optional] in boolean aIgnoreRootScrollFrame);
>+                      [optional] in boolean aIgnoreRootScrollFrame,
>+                      [optional] in float aPressure,
>+                      [optional] in unsigned short aInputSourceArg);
I was a bit worried about optional aPressure, since it gives default value 0, IIRC.
But looks like that is what pressure's default value is already now.
Attachment #651040 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/67d9cf5ea455
https://hg.mozilla.org/mozilla-central/rev/67d9cf5ea455
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Depends on: 784016
You need to log in before you can comment on or make changes to this bug.