782091 - multichannel opus test files

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

Bug 748144 adds support for multichannel Opus files, but doesn't have a license-compatible test file.

This bug is about creating such a file and adding it to the mochitests. We should verify playback completion and mozChannels.

Comment 1

[Timothy B. Terriberry (:derf)]

(In reply to Ralph Giles (:rillian) from comment #0)
> Bug 748144 adds support for multichannel Opus files, but doesn't have a
> license-compatible test file.

I sat down with Monty and we made a set of files:
http://people.xiph.org/~tterribe/opus/multichannel/

I've confirmed with Monty that these can be used as public domain (quote: "They may be used to troll me indefinitely, and I expect they will.").

Comment 2

[Ralph Giles (:rillian)]

Thanks!

BTW, Monty said he also made a higher quality recording at home. Hopefully he will forward those when the conference is over so we can make higher quality examples.

Comment 3

[Ralph Giles (:rillian)]

Monty lost his recording, so maybe we should go with derf's set for now, despite the poor quality.

It would also be nice to have some kind of automated verification of the output to catch issues like bug 787788. E.g. we could port opus_compare to js and run that on the output (but this requires a lossless original in the test suite). A simpler idea is computing a few moments in each frequency band, which would at least have found the wildly-off downmix coefficient.

Comment 4

[Ralph Giles (:rillian)]

Attachment: add tim and monty's test files

I've not made anything better in the intervening six months, so here's a patch to add the basic speaker-matching tests Tim and Monty created.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8324f2f4007b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8324f2f4007b