782155 - Set MACOSX_DEPLOYMENT_TARGET to 10.6 for all architectures

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nomis101]

Attachment: Patch

Now that we have removed 10.5 support on trunk, we can set MACOSX_DEPLOYMENT_TARGET to 10.6 for all architectures. This patch also cleans up unsupported powerpc-apple-darwin.

Comment 1

[Ed Morley [:emorley]]

Isn't the case statement redundant now? :-)
Also presume js/src/configure.in will need changing too.

Comment 2

[Nomis101]

(In reply to Ed Morley [:edmorley] from comment #1)
> Also presume js/src/configure.in will need changing too.
The JS part is Bug 782156.

Comment 3

[Ed Morley [:emorley]]

Oh ok - not sure why a separate bug? 
Just didn't know about the JS part since it wasn't mentioned in comment 0 or filed in a build config component (I don't watch the JS component) :-)

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 651228 [details] [diff] [review]
Patch

Review of attachment 651228 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +909,3 @@
>              ;;
>            x86_64)
>              export MACOSX_DEPLOYMENT_TARGET=10.6

You can just get rid of the case statement entirely here, and always set it to 10.6.

Comment 5

[Nomis101]

Attachment: Patch v2

You mean like this?

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 651500 [details] [diff] [review]
Patch v2

Review of attachment 651500 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16127a6e0bf3

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/16127a6e0bf3