Closed Bug 782155 Opened 7 years ago Closed 7 years ago

Set MACOSX_DEPLOYMENT_TARGET to 10.6 for all architectures

Categories

(Firefox Build System :: General, defect, trivial)

x86
macOS
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: Nomis101, Assigned: Nomis101)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
Now that we have removed 10.5 support on trunk, we can set MACOSX_DEPLOYMENT_TARGET to 10.6 for all architectures. This patch also cleans up unsupported powerpc-apple-darwin.
Attachment #651228 - Flags: review?(ted.mielczarek)
Isn't the case statement redundant now? :-)
Also presume js/src/configure.in will need changing too.
(In reply to Ed Morley [:edmorley] from comment #1)
> Also presume js/src/configure.in will need changing too.
The JS part is Bug 782156.
Oh ok - not sure why a separate bug? 
Just didn't know about the JS part since it wasn't mentioned in comment 0 or filed in a build config component (I don't watch the JS component) :-)
Comment on attachment 651228 [details] [diff] [review]
Patch

Review of attachment 651228 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +909,3 @@
>              ;;
>            x86_64)
>              export MACOSX_DEPLOYMENT_TARGET=10.6

You can just get rid of the case statement entirely here, and always set it to 10.6.
Attachment #651228 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → Nomis101
Attached patch Patch v2Splinter Review
You mean like this?
Attachment #651500 - Flags: review?(ted.mielczarek)
Duplicate of this bug: 782156
Comment on attachment 651500 [details] [diff] [review]
Patch v2

Review of attachment 651500 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #651500 - Flags: review?(ted.mielczarek) → review+
Attachment #651228 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/16127a6e0bf3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.