Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Set MACOSX_DEPLOYMENT_TARGET to 10.6 for all architectures

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Nomis101, Assigned: Nomis101)

Tracking

Trunk
mozilla17
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

3.62 KB, patch
ted
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 651228 [details] [diff] [review]
Patch

Now that we have removed 10.5 support on trunk, we can set MACOSX_DEPLOYMENT_TARGET to 10.6 for all architectures. This patch also cleans up unsupported powerpc-apple-darwin.
(Assignee)

Updated

5 years ago
Attachment #651228 - Flags: review?(ted.mielczarek)

Comment 1

5 years ago
Isn't the case statement redundant now? :-)
Also presume js/src/configure.in will need changing too.
(Assignee)

Comment 2

5 years ago
(In reply to Ed Morley [:edmorley] from comment #1)
> Also presume js/src/configure.in will need changing too.
The JS part is Bug 782156.

Comment 3

5 years ago
Oh ok - not sure why a separate bug? 
Just didn't know about the JS part since it wasn't mentioned in comment 0 or filed in a build config component (I don't watch the JS component) :-)
Comment on attachment 651228 [details] [diff] [review]
Patch

Review of attachment 651228 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +909,3 @@
>              ;;
>            x86_64)
>              export MACOSX_DEPLOYMENT_TARGET=10.6

You can just get rid of the case statement entirely here, and always set it to 10.6.
Attachment #651228 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → Nomis101
(Assignee)

Comment 5

5 years ago
Created attachment 651500 [details] [diff] [review]
Patch v2

You mean like this?
Attachment #651500 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Duplicate of this bug: 782156
Comment on attachment 651500 [details] [diff] [review]
Patch v2

Review of attachment 651500 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #651500 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

5 years ago
Attachment #651228 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/16127a6e0bf3
Flags: in-testsuite-
Keywords: checkin-needed

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/16127a6e0bf3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.