Closed Bug 782214 Opened 7 years ago Closed 7 years ago

Auto detect android api version for x86 (port bug 780072 to nspr)

Categories

(NSPR :: NSPR, defect, P2)

x86
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

No description provided.
Attached patch fixSplinter Review
Attachment #669436 - Flags: review?(wtc)
Comment on attachment 669436 [details] [diff] [review]
fix

r=wtc. Should the case statement have a *) case at the end?

Ted, could you also review this?  Thanks.
Attachment #669436 - Flags: superreview?(ted.mielczarek)
Attachment #669436 - Flags: review?(wtc)
Attachment #669436 - Flags: review+
Comment on attachment 669436 [details] [diff] [review]
fix

Review of attachment 669436 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, this looks fine.
Attachment #669436 - Flags: superreview?(ted) → superreview+
Priority: -- → P2
Target Milestone: --- → 4.9.5
I edited the comment in mozilla/nsprpub/configure.in a little
(added "The" and changed "per" to "for each") before I checked
in the patch. Thanks for the patch.

Patch checked in on the NSPR trunk (NSPR 4.9.6).

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.338; previous revision: 1.337
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.341; previous revision: 1.340
done
Assignee: wtc → m_kato
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: 4.9.5 → 4.9.6
You need to log in before you can comment on or make changes to this bug.