Last Comment Bug 782232 - Regression: "false" returned as nsresult in nsObjectLoadingContent.cpp
: Regression: "false" returned as nsresult in nsObjectLoadingContent.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Aryeh Gregor (:ayg) (next working March 28-April 26)
:
: Benjamin Smedberg [:bsmedberg]
Mentors:
Depends on:
Blocks: 745030 nsresult-enum
  Show dependency treegraph
 
Reported: 2012-08-13 04:10 PDT by Aryeh Gregor (:ayg) (next working March 28-April 26)
Modified: 2012-08-14 17:53 PDT (History)
2 users (show)
ayg: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.69 KB, patch)
2012-08-13 04:43 PDT, Aryeh Gregor (:ayg) (next working March 28-April 26)
jaas: review+
Details | Diff | Splinter Review

Description Aryeh Gregor (:ayg) (next working March 28-April 26) 2012-08-13 04:10:56 PDT
Bug 745030 added return paths to nsObjectLoadingContent::IsPluginEnabledForType and nsObjectLoadingContent::InstantiatePluginInstance that return false, but the return type is nsresult.  This means they're really returning NS_OK, which isn't what you want.
Comment 1 Aryeh Gregor (:ayg) (next working March 28-April 26) 2012-08-13 04:43:28 PDT
Created attachment 651324 [details] [diff] [review]
Patch

Try: https://tbpl.mozilla.org/?tree=Try&rev=3ee5af5abc71
Comment 2 John Schoenick [:johns] 2012-08-13 10:53:07 PDT
Good catch, this is just C&P fail for using ::GetInst() instead of XPCOM for grabbing pluginhost (it shouldn't ever really fail though)
Comment 3 Aryeh Gregor (:ayg) (next working March 28-April 26) 2012-08-14 03:14:55 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d595c62abcb
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-14 17:53:00 PDT
https://hg.mozilla.org/mozilla-central/rev/2d595c62abcb

Note You need to log in before you can comment on or make changes to this bug.