The default bug view has changed. See this FAQ.

Regression: "false" returned as nsresult in nsObjectLoadingContent.cpp

RESOLVED FIXED in mozilla17

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 745030 added return paths to nsObjectLoadingContent::IsPluginEnabledForType and nsObjectLoadingContent::InstantiatePluginInstance that return false, but the return type is nsresult.  This means they're really returning NS_OK, which isn't what you want.
Created attachment 651324 [details] [diff] [review]
Patch

Try: https://tbpl.mozilla.org/?tree=Try&rev=3ee5af5abc71
Attachment #651324 - Flags: review?(joshmoz)
Good catch, this is just C&P fail for using ::GetInst() instead of XPCOM for grabbing pluginhost (it shouldn't ever really fail though)

Updated

5 years ago
Attachment #651324 - Flags: review?(joshmoz) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d595c62abcb
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/2d595c62abcb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.