782271 - signature generation doubles single quotes unnecessarily

Status: RESOLVED WONTFIX

(Socorro :: Backend, task)

Description

[K Lars Lohn [:lars] [:klohn]]

in signatureUtilities.py (and signature_utilities.py), the base class will quote single quotes by doubling them.  While this may be appropriate for Java signatures, it messes up C signatures.  

Move the code that quotes single quotes into the Java sub-class rather than the base class.

Comment 1

[K Lars Lohn [:lars] [:klohn]]

I'm going through old issues and closing or resolving them.  Is this still and issue that I ought to be addressing?

Comment 2

[Benjamin Smedberg]

I really don't know why we're doubling it in any case. I found example of doubling in both Java and C++ that looks "extra":

Java: https://crash-stats.mozilla.com/report/index/6fc7a0c7-c0a8-4baf-8e66-b7b002140225
C++: https://crash-stats.mozilla.com/report/index/451773cd-a5e9-4810-873e-f6ac32140225

(supersearch: https://crash-stats.mozilla.com/search/?signature=~%27&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform)

If I were guessing, I suspect the doubling comes from some very old SQL injection issue which doesn't apply now that we're using variable bindings properly.

Comment 3

[K Lars Lohn [:lars] [:klohn]]

old and outdated - refile if this is still needed.