Closed Bug 782344 Opened 12 years ago Closed 11 years ago

Remove unreadable elements from parsed articles

Categories

(Firefox for Android Graveyard :: Reader View, defect, P2)

ARM
Android
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: bnicholson, Assigned: bnicholson)

Details

Attachments

(1 file)

STR: Go to http://www.amazon.com/gp/aw/s/ref=is_box_?k=50+shades+of+grey Expected result: The page isn't detected as readable and no icon appears Actual result: The reader mode icon does appear, and clicking it simply shows a single <select> element.
<select> elements will never have readable content, so we should remove them. In this case, the change makes http://www.amazon.com/gp/aw/s/ref=is_box_?k=50+shades+of+grey no longer readable (as desired).
Attachment #651471 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 651471 [details] [diff] [review] remove <select> elements from reader pages Review of attachment 651471 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #651471 - Flags: review?(lucasr.at.mozilla) → review+
We may also want to remove other elements while we're here...I've seen <hr>s, <button>s, and other things that shouldn't be considered readable.
(In reply to Brian Nicholson (:bnicholson) from comment #3) > We may also want to remove other elements while we're here...I've seen > <hr>s, <button>s, and other things that shouldn't be considered readable. Good point, go for it.
Summary: <select> elements appear in parsed reader mode page → Remove unreadable elements from parsed articles
Priority: -- → P2
No longer blocks: 777557
I'm not seeing this issue any more.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: