782382 - When sending command data fails, we get a syntax error

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

When running the pandaboard smoketest, I got this error:

Process Process-1:
Traceback (most recent call last):
  File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "/home/wlach/src/autophone/worker.py", line 279, in loop
    self.dm.pushFile(job['apkpath'], pathOnDevice)
  File "/home/wlach/src/autophone/local/lib/python2.7/site-packages/mozdevice/devicemanagerSUT.py", line 322, in pushFile
    'data': data }])
  File "/home/wlach/src/autophone/local/lib/python2.7/site-packages/mozdevice/devicemanagerSUT.py", line 153, in runCmds
    self.sendCmds(cmdlist, outputfile, timeout)
  File "/home/wlach/src/autophone/local/lib/python2.7/site-packages/mozdevice/devicemanagerSUT.py", line 133, in sendCmds
    self._doCmds(cmdlist, outputfile, timeout)
  File "/home/wlach/src/autophone/local/lib/python2.7/site-packages/mozdevice/devicemanagerSUT.py", line 191, in _doCmds
    "only sent %s" % (len(cmd['data'], sent)))
TypeError: len() takes exactly one argument (2 given)

If we hit this exception we're probably pretty hosed anyway, but we should probably fix this syntax error regardless.

Comment 1

[William Lachance (:wlach)]

Attachment: Fix syntax error

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 651502 [details] [diff] [review]
Fix syntax error

Review of attachment 651502 [details] [diff] [review]:
-----------------------------------------------------------------

yes, the last and final bug was finally found in devicemanagerSUT!  Now we can profit.

Comment 3

[William Lachance (:wlach)]

Yes, we can all retire now. Let me be the first to say that it was great working with all of you!

Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/d3faac91b575

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d3faac91b575