782396 - Should be able to disable logging behaviour of SUTAgent (and that should be the default)

Status: RESOLVED FIXED

(Testing Graveyard :: SUTAgent, defect)

Description

[William Lachance (:wlach)]

As discussed:

We speculate that the frequent writes to the sdcard to store a log of information are causing problems. We should experiment with disabling this to see if it helps. Better yet, let's make it configurable and default it to off. ;)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: disable the sut command logging by default, allow it to turn on via ini file (1.0)

this does what I say it does.

I found in testing that we need the registration server bits defined in the ini file.  Personally I think we should remove that, but I wanted to get this patch up for review.  We can r- and fix our requirements for ini file contents, or file a followup bug.

Comment 2

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Comment on attachment 651912 [details] [diff] [review]
disable the sut command logging by default, allow it to turn on via ini file (1.0)

Review of attachment 651912 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Maybe best to address the ini concerns in a follow up bug.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

found out I was incorrect in my original assessment of the .ini file parsing in SUTAgent.  This is all good now:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76a7b5eea991

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/76a7b5eea991