Last Comment Bug 782404 - Unhide some skipped xpcshell-tests
: Unhide some skipped xpcshell-tests
Product: MailNews Core
Classification: Components
Component: Testing Infrastructure (show other bugs)
: 12
: All All
-- normal (vote)
: Thunderbird 17.0
Assigned To: Mark Banner (:standard8)
Depends on:
  Show dependency treegraph
Reported: 2012-08-13 13:46 PDT by Mark Banner (:standard8)
Modified: 2012-08-14 06:42 PDT (History)
1 user (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

The fix (6.76 KB, patch)
2012-08-13 13:46 PDT, Mark Banner (:standard8)
Pidgeot18: review+
Details | Diff | Splinter Review
The fix v2 (6.50 KB, patch)
2012-08-14 06:38 PDT, Mark Banner (:standard8)
no flags Details | Diff | Splinter Review

Description User image Mark Banner (:standard8) 2012-08-13 13:46:03 PDT
Created attachment 651523 [details] [diff] [review]
The fix

We have various xpcshell tests that are "skipped" by doing something like function run_test() { return; ... }

We should convert those to use skip-if as a) it exposes the fact they are skipped to the unit test logs, and b) we get those tests run ever so slightly faster as we don't have to load xpcshell, the python script can just dump the skip notification.

Attached is a patch of the ones I found, I went through all the tests, so I should have all of them.
Comment 1 User image Joshua Cranmer [:jcranmer] 2012-08-14 06:06:48 PDT
Comment on attachment 651523 [details] [diff] [review]
The fix

Review of attachment 651523 [details] [diff] [review]:

::: mailnews/imap/test/unit/xpcshell.ini
@@ +45,5 @@
>  [test_mailboxes.js]
>  [test_nsIMsgFolderListenerIMAP.js]
>  [test_offlinePlayback.js]
>  [test_offlineStoreLocking.js]
> +skip-if = os == "win"

Is there a bug filed to fix this test on windows? If not, please file one and note it in a comment here.

::: mailnews/news/test/unit/xpcshell.ini
@@ +11,5 @@
>  [test_getNewsMessage.js]
>  [test_internalUris.js]
>  [test_nntpContentLength.js]
> +# The server doesn't support returning sizes!
> +skip-if = true

Ditto here.
Comment 2 User image Mark Banner (:standard8) 2012-08-14 06:38:29 PDT
Created attachment 651746 [details] [diff] [review]
The fix v2

Updated patch with comments and for the fact that bug 772712 just landed, removing the need to skip that test now.
Comment 3 User image Mark Banner (:standard8) 2012-08-14 06:42:54 PDT
Checked in:

Note You need to log in before you can comment on or make changes to this bug.