782404 - Unhide some skipped xpcshell-tests

Status: RESOLVED FIXED

(MailNews Core :: Testing Infrastructure, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

We have various xpcshell tests that are "skipped" by doing something like function run_test() { return; ... }

We should convert those to use skip-if as a) it exposes the fact they are skipped to the unit test logs, and b) we get those tests run ever so slightly faster as we don't have to load xpcshell, the python script can just dump the skip notification.

Attached is a patch of the ones I found, I went through all the tests, so I should have all of them.

Comment 1

[Joshua Cranmer [:jcranmer]]

Comment on attachment 651523 [details] [diff] [review]
The fix

Review of attachment 651523 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/imap/test/unit/xpcshell.ini
@@ +45,5 @@
>  [test_mailboxes.js]
>  [test_nsIMsgFolderListenerIMAP.js]
>  [test_offlinePlayback.js]
>  [test_offlineStoreLocking.js]
> +skip-if = os == "win"

Is there a bug filed to fix this test on windows? If not, please file one and note it in a comment here.

::: mailnews/news/test/unit/xpcshell.ini
@@ +11,5 @@
>  [test_getNewsMessage.js]
>  [test_internalUris.js]
>  [test_nntpContentLength.js]
> +# The server doesn't support returning sizes!
> +skip-if = true

Ditto here.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix v2

Updated patch with comments and for the fact that bug 772712 just landed, removing the need to skip that test now.

Comment 3

[Mark Banner (:standard8)]

Checked in: https://hg.mozilla.org/comm-central/rev/f0e8916a9ad1