The default bug view has changed. See this FAQ.

Fix JSDOMParser's removeChild()

RESOLVED FIXED in Firefox 16

Status

()

Firefox for Android
Reader View
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 17
All
Android
Points:
---

Firefox Tracking Flags

(firefox16- fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Need to clear the removed child'd parentNode reference.
(Assignee)

Comment 1

5 years ago
Created attachment 651608 [details] [diff] [review]
Clear parentNode reference when removing a child in JSDOMParser
Attachment #651608 - Flags: review?(bnicholson)
(Assignee)

Comment 2

5 years ago
This patch fixes reader mode in arstechnica, for example.
(Assignee)

Updated

5 years ago
tracking-firefox16: --- → ?
Comment on attachment 651608 [details] [diff] [review]
Clear parentNode reference when removing a child in JSDOMParser

Nice catch...I thought it had that already, but apparently not.
Attachment #651608 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 4

5 years ago
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/130965086c2a
(Assignee)

Updated

5 years ago
Assignee: nobody → lucasr.at.mozilla
tracking-firefox16: ? → -
https://hg.mozilla.org/mozilla-central/rev/130965086c2a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
(Assignee)

Comment 6

5 years ago
Comment on attachment 651608 [details] [diff] [review]
Clear parentNode reference when removing a child in JSDOMParser

[Approval Request Comment]
User impact if declined: Readability check will simply fail on certain pages (e.g. arstechnica.com). Reader mode becomes unavailable for those pages as a result.
Testing completed (on m-c, etc.): A few days on m-c, no regressions.
Risk to taking this patch (and alternatives if risky): Very low, trivial one-line patch.
String or UUID changes made by this patch: None.
Attachment #651608 - Flags: approval-mozilla-aurora?
Attachment #651608 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

5 years ago
Pushed to mozilla-aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/fd0cdea0b171

Updated

5 years ago
status-firefox16: --- → fixed
You need to log in before you can comment on or make changes to this bug.