78255 - accel+shift+S as shortcut for Save As for editor files

Status: VERIFIED WONTFIX

(Core :: DOM: Editor, enhancement, P5)

Description

[sairuh (rarely reading bugmail)]

it'd be good to have a keyboard shortcut for save for editor files.
accel+shift+S doesn't seem to be used, afaik [eg, ctrl+shift+S].

on a related note, should this shortcut be applied to mail compose
--specifically Save As File? cc'ing nbaca, jglick and ducarroz for their
comments.

Comment 1

[Matthew T (active 1999-2002)]

Excellent idea!

Comment 2

[jglick]

For Editor, it would open the "Save Page as" dialog, correct? Aaron should 
verify this key combo is available, and if so, sounds like a nice area.

As for mail, using the same accel for Save as File would be nice too.

Currently, File -->Save as--> File opens a "Export to Text" (bad title) dialog 
if no html and the "Save Page as" dialog if html is included. Shouldn't it be 
opening the same dialog for both with the option to save as either .txt or 
.html?

Comment 3

[sairuh (rarely reading bugmail)]

jglick, afaik accel+shift+S isn't being used elsewhere... other folx, lemme know
if it is!

Comment 4

[rubydoo123]

good enhancement request, marking as such and moving to future

Comment 5

[Charles Manske]

Attachment: Trivial addition of new key accelerator for Composer

Comment 6

[Charles Manske]

Oh com'on! Adding a new key is about as easy as it gets! It took me 5' 33" to do
this, from the time I read bug to finishing this comment!
(I didn't do mail, but just as easy)

Comment 7

[sairuh (rarely reading bugmail)]

thanks, charley!

jglick, ducarroz: not sure if there should be a separate bug for the mail
compose case, but filed bug 78607 just in case [if it'd be covered by this one,
feel free to dup].

Comment 8

[timeless]

r=timeless, but we need to get the spec updated.

isn't severity:enhancement good enough?

Comment 9

[Kathleen :Brade]

I don't understand why we need a keybinding for save as...
Don't we have more important bugs to fix instead of this?

I *really*, *really*, *REALLY* don't want this checked in.

Also, please don't check this in until I have checked in much more critical 
keybinding changes so I don't have to deal with conflicts.

Comment 10

[rubydoo123]

moving back to future, this is so not needed in 6.5, the time spent on this bug 
should have been spent on higher priority bugs, regardless of the time or effort 
it took.

Comment 11

[Charles Manske]

I don't think there's any conficts -- Kathy?
keybinding code is checked in, but commented out in editorOverlay.xul

Comment 12

[Kathleen :Brade]

It's not about "conflicts" it's about doing what makes sense.
I don't know of any application that has a keybinding for Save as (except those 
which only offer Save As and no "save").

I feel very strongly that we should NOT be adding keybindings to menu items just 
because we can.

I would like to see this bug resolved as WONTFIX.

Comment 13

[Simon Fraser [no longer active]]

I'm with Kathy. We don't want this; the commented out code should be removed.

Comment 14

[Charles Manske]

I agree. It got checked in sort of "by accident"

Comment 15

[sujay]

verified.

Comment 16

[Matthew T (active 1999-2002)]

Just for the record ...

> I don't know of any application that has a keybinding for Save as

*   Adobe Illustrator 9.0 (Shift+accel+S)
*   Adobe Photoshop 6.0 (Shift+accel+S)
*   AppleWorks 6.0 (Shift+accel+S)
*   Corel Draw 8.0 (Shift+accel+S)
*   Corel Photo-Paint (Shift+accel+S)
*   Jasc Paint Shop Pro 7.0 (F12)
*   Microsoft Excel 2000 (F12)
*   Microsoft PowerPoint 2000 (F12)
*   Microsoft Word 2000 (F12)
*   Quark Xpress (Alt+accel+S)
*   WorldText 1.0 (Shift+accel+S)

These are just the apps I found on my Mac and on the Windows PCs at work which 
have such a shortcut. As you can see, with the exception of Microsoft Office, 
most apps use Shift+accel+S as sairuh suggested. In fact, if we had bugs/RFEs 
for doing anything *else* with Shift+accel+S, we'd probably have to wontfix 
them because Shift+accel+S is too strongly associated with Save As.