1.72 KB, patch
|Details | Diff | Splinter Review|
it'd be good to have a keyboard shortcut for save for editor files. accel+shift+S doesn't seem to be used, afaik [eg, ctrl+shift+S]. on a related note, should this shortcut be applied to mail compose --specifically Save As File? cc'ing nbaca, jglick and ducarroz for their comments.
For Editor, it would open the "Save Page as" dialog, correct? Aaron should verify this key combo is available, and if so, sounds like a nice area. As for mail, using the same accel for Save as File would be nice too. Currently, File -->Save as--> File opens a "Export to Text" (bad title) dialog if no html and the "Save Page as" dialog if html is included. Shouldn't it be opening the same dialog for both with the option to save as either .txt or .html?
jglick, afaik accel+shift+S isn't being used elsewhere... other folx, lemme know if it is!
good enhancement request, marking as such and moving to future
Assignee: beppe → brade
Severity: normal → enhancement
Priority: -- → P5
Target Milestone: --- → Future
Created attachment 32941 [details] [diff] [review] Trivial addition of new key accelerator for Composer
Oh com'on! Adding a new key is about as easy as it gets! It took me 5' 33" to do this, from the time I read bug to finishing this comment! (I didn't do mail, but just as easy)
Target Milestone: Future → mozilla0.9.2
thanks, charley! jglick, ducarroz: not sure if there should be a separate bug for the mail compose case, but filed bug 78607 just in case [if it'd be covered by this one, feel free to dup].
Keywords: helpwanted → patch, review
r=timeless, but we need to get the spec updated. isn't severity:enhancement good enough?
Assignee: brade → cmanske
Keywords: review → approval
I don't understand why we need a keybinding for save as... Don't we have more important bugs to fix instead of this? I *really*, *really*, *REALLY* don't want this checked in. Also, please don't check this in until I have checked in much more critical keybinding changes so I don't have to deal with conflicts.
moving back to future, this is so not needed in 6.5, the time spent on this bug should have been spent on higher priority bugs, regardless of the time or effort it took.
Target Milestone: mozilla0.9.2 → Future
I don't think there's any conficts -- Kathy? keybinding code is checked in, but commented out in editorOverlay.xul
Status: NEW → ASSIGNED
It's not about "conflicts" it's about doing what makes sense. I don't know of any application that has a keybinding for Save as (except those which only offer Save As and no "save"). I feel very strongly that we should NOT be adding keybindings to menu items just because we can. I would like to see this bug resolved as WONTFIX.
I'm with Kathy. We don't want this; the commented out code should be removed.
I agree. It got checked in sort of "by accident"
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → VERIFIED
Just for the record ... > I don't know of any application that has a keybinding for Save as * Adobe Illustrator 9.0 (Shift+accel+S) * Adobe Photoshop 6.0 (Shift+accel+S) * AppleWorks 6.0 (Shift+accel+S) * Corel Draw 8.0 (Shift+accel+S) * Corel Photo-Paint (Shift+accel+S) * Jasc Paint Shop Pro 7.0 (F12) * Microsoft Excel 2000 (F12) * Microsoft PowerPoint 2000 (F12) * Microsoft Word 2000 (F12) * Quark Xpress (Alt+accel+S) * WorldText 1.0 (Shift+accel+S) These are just the apps I found on my Mac and on the Windows PCs at work which have such a shortcut. As you can see, with the exception of Microsoft Office, most apps use Shift+accel+S as sairuh suggested. In fact, if we had bugs/RFEs for doing anything *else* with Shift+accel+S, we'd probably have to wontfix them because Shift+accel+S is too strongly associated with Save As.
You need to log in before you can comment on or make changes to this bug.