Closed
Bug 782605
Opened 12 years ago
Closed 12 years ago
Make nsNPAPIPluginInstance::SetCached infallible
Categories
(Core Graveyard :: Plug-ins, enhancement)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
|
2.25 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Currently it purports to return nsresult, but always returns NS_OK. This is a type error in _setvalue() in nsNPAPIPlugin.cpp, since it ostensibly returns NPError but in one place returns the result of SetCached(). So let's just make it officially infallible so it's not an issue.
|
Assignee | |
Comment 1•12 years ago
|
||
(This is the only caller.)
Attachment #651704 -
Flags: review?(roc)
Attachment #651704 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f7d474fb52 Green try: https://tbpl.mozilla.org/?tree=Try&rev=da4047717ef7
Flags: in-testsuite-
|
|
Assignee | |
Comment 3•12 years ago
|
||
Sorry, correct revision link: https://hg.mozilla.org/integration/mozilla-inbound/rev/66ae8a550cfc
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/66ae8a550cfc
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•