Make nsNPAPIPluginInstance::SetCached infallible

RESOLVED FIXED in mozilla17

Status

()

Core
Plug-ins
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Currently it purports to return nsresult, but always returns NS_OK.  This is a type error in _setvalue() in nsNPAPIPlugin.cpp, since it ostensibly returns NPError but in one place returns the result of SetCached().  So let's just make it officially infallible so it's not an issue.
Created attachment 651704 [details] [diff] [review]
Patch

(This is the only caller.)
Attachment #651704 - Flags: review?(roc)
Attachment #651704 - Flags: review?(roc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f7d474fb52

Green try: https://tbpl.mozilla.org/?tree=Try&rev=da4047717ef7
Flags: in-testsuite-
Sorry, correct revision link: https://hg.mozilla.org/integration/mozilla-inbound/rev/66ae8a550cfc
https://hg.mozilla.org/mozilla-central/rev/66ae8a550cfc
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.