Last Comment Bug 782667 - Add a JS source view to the profiler
: Add a JS source view to the profiler
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Benoit Girard (:BenWa)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-14 08:55 PDT by Benoit Girard (:BenWa)
Modified: 2012-08-18 17:44 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
screenshot (134.49 KB, image/png)
2012-08-14 15:05 PDT, Benoit Girard (:BenWa)
no flags Details

Description Benoit Girard (:BenWa) 2012-08-14 08:55:04 PDT
Concept:
1) Right click on a js frame and select 'View JS Source'.
2) Open a view into the JS source showing the sample count on the left-hand side.
Comment 1 Benoit Girard (:BenWa) 2012-08-14 09:01:36 PDT
Work is already started in the cleopatra and Gecko Profiler repo. The only part that isn't finished is the source view.
Comment 2 :Ehsan Akhgari (busy, don't ask for review please) 2012-08-14 10:11:33 PDT
(In reply to comment #1)
> Work is already started in the cleopatra and Gecko Profiler repo. The only part
> that isn't finished is the source view.

It would be nice if we could use Orion for the source view component, as we're already using that for our developer tools.
Comment 3 Benoit Girard (:BenWa) 2012-08-14 15:05:06 PDT
I have it working using a trivial list of div but it should be easy to use Orion instead, for someone who understand Orion. For that reason I wont plan to extend this simple view much.

Changes are now deployed.
Comment 4 Benoit Girard (:BenWa) 2012-08-14 15:05:43 PDT
Created attachment 651901 [details]
screenshot
Comment 5 Jim Blandy :jimb 2012-08-15 18:24:34 PDT
For what it's worth, Debugger will soon have the ability to retrieve the true source code of any script, including those passed to eval or otherwise generated dynamically. See bug 637572 comment 22.
Comment 6 Benoit Girard (:BenWa) 2012-08-18 17:44:55 PDT
(In reply to Jim Blandy :jimb from comment #5)
> For what it's worth, Debugger will soon have the ability to retrieve the
> true source code of any script, including those passed to eval or otherwise
> generated dynamically. See bug 637572 comment 22.

Excellent, once bug 751034 lands we're going to start refactoring the profiler to use this.

Note You need to log in before you can comment on or make changes to this bug.