Add a JS source view to the profiler

RESOLVED FIXED

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Concept:
1) Right click on a js frame and select 'View JS Source'.
2) Open a view into the JS source showing the sample count on the left-hand side.
(Assignee)

Comment 1

5 years ago
Work is already started in the cleopatra and Gecko Profiler repo. The only part that isn't finished is the source view.
(In reply to comment #1)
> Work is already started in the cleopatra and Gecko Profiler repo. The only part
> that isn't finished is the source view.

It would be nice if we could use Orion for the source view component, as we're already using that for our developer tools.
(Assignee)

Comment 3

5 years ago
I have it working using a trivial list of div but it should be easy to use Orion instead, for someone who understand Orion. For that reason I wont plan to extend this simple view much.

Changes are now deployed.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

5 years ago
Created attachment 651901 [details]
screenshot
(Assignee)

Updated

5 years ago
Assignee: nobody → bgirard

Comment 5

5 years ago
For what it's worth, Debugger will soon have the ability to retrieve the true source code of any script, including those passed to eval or otherwise generated dynamically. See bug 637572 comment 22.
(Assignee)

Comment 6

5 years ago
(In reply to Jim Blandy :jimb from comment #5)
> For what it's worth, Debugger will soon have the ability to retrieve the
> true source code of any script, including those passed to eval or otherwise
> generated dynamically. See bug 637572 comment 22.

Excellent, once bug 751034 lands we're going to start refactoring the profiler to use this.
You need to log in before you can comment on or make changes to this bug.