782717 - Link from reviews back to the patch

Status: RESOLVED INCOMPLETE

(bugzilla.mozilla.org :: Splinter, enhancement, P5)

Description

[David Teller [:Yoric] - still alive but not very active]

Let's consider the following patch:

«
if (foo) {
 // ... do something
}
// ...
if (foo) {
 // ... do something else
}
»

When a reviewer adds a comment pertaining to line |if(foo) {|, the context is generally lost. What the submitter will see is something along the lines of

«
+ if(foo) {
Why?
»

This is not very informative (especially when the reviewer is monosyllabic, and we have quite a few of these) and the submitter has to guess whether the comment was related to the first occurrence of |if(foo) {| or the second. This can get even worse when the only context displayed after the review is some empty line.

We could make this much nicer on the users by making the following change:
- in the message, each line starts with a line number;
- each line number links back to the corresponding line in the Splinter Review vies of the patch.

As follows

«
l. 23 +   if(foo) {
Why?
»

Comment 1

[Kohei]

Splinter is retiring.