78273 - Embedding API: list avail fonts

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[kill this account]

Applications embedding gecko need the list of available fonts for a given
language group so users can set the fallback preferences.

Comment 1

[rbs]

http://lxr.mozilla.org/seamonkey/source/gfx/idl/nsIFontEnumerator.idl

Comment 2

[kill this account]

Thanks for pointing out the existing API.

The embedding effort has requested some slight changes:

  return a nsISimpleEnumerator instead of an array of strings.

  simpilify as much as possible
   - we can make EnumerateAllFonts a sub case of EnumerateFonts
     by passing in a null aLangGroup and aGeneric
   - we can eliminate HaveFontFor.


(the new API actually calls nsIFontEnumerator.

Comment 3

[Frank Tang]

who is reviewing this ?

Comment 4

[Phil Peterson]

TM to 0.9.2 per PDT triage (it's OK to check it in by Friday or after 0.9.2 branch).

Comment 5

[kill this account]

Attachment: patch with new font prefs API

Comment 6

[Frank Tang]

need nsSetupRegistry.cpp change on mac
also, we should call hasMoreElements in js first before we call getNext.

Comment 7

[Frank Tang]

Attachment: nsSetupRegistry.cpp changes needed for mac

Comment 8

[Frank Tang]

Please change 
+          while ((fontName = aDataObject.getNext()) != null) {
+            fontName = 
fontName.QueryInterface(Components.interfaces.nsISupportsWString);
to 
+          while (aDataObject.hasMoreElements()) {
+            fontName = aDataObject.getNext();
+            fontName = 
fontName.QueryInterface(Components.interfaces.nsISupportsWString);

otherwise, it won't run on mac.

Comment 9

[kill this account]

Attachment: patch with win/mac build changes

Comment 10

[Frank Tang]

please change according to my comment. we also need to check in mac project file 
for the IDL and nsFontList.cpp . please ask jbetak to review pref-fonts.js 
changes. for the rest, r=ftang

Comment 11

[[e-mail] (away - not reading bugmail)]

r=jbetak for the JS part of the patch

Comment 12

[[e-mail] (away - not reading bugmail)]

additional comment: please try to eliminate all dumps you can spare

Comment 13

[kill this account]

I'll remove the 

 dump("got font list, "+fileName+" "+lineNum+"\n");

but ftang specifically ask me to add the dump in the exception

 catch(e)
   {
+    dump("failed to get font list or pref object: "+e+", "+fileName+" 
"+lineNum+"\n");
   }

Comment 14

[Christopher Blizzard (:blizzard)]

What is the lang group exactly?  Can you expand this comment with examples as well?

+   * @param aLangGroup limits the fonts to fonts in this language 
+   *          group.

+    return NS_ERROR_UNEXPECTED;;

two semicolons?  legal but odd. :)

Fix those and you have an sr=blizzard

Comment 15

[kill this account]

checked in

Comment 16

[Teruko Kobayashi]

nsIFontList API is there.