Last Comment Bug 782916 - Do not compare nsresult to noErr
: Do not compare nsresult to noErr
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Internationalization (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla17
Assigned To: :Aryeh Gregor (working until September 2)
:
Mentors:
Depends on:
Blocks: nsresult-enum-class
  Show dependency treegraph
 
Reported: 2012-08-15 03:56 PDT by :Aryeh Gregor (working until September 2)
Modified: 2012-08-17 19:23 PDT (History)
1 user (show)
ayg: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.16 KB, patch)
2012-08-15 03:58 PDT, :Aryeh Gregor (working until September 2)
smontagu: review+
Details | Diff | Splinter Review

Description :Aryeh Gregor (working until September 2) 2012-08-15 03:56:44 PDT

    
Comment 1 :Aryeh Gregor (working until September 2) 2012-08-15 03:58:19 PDT
Created attachment 652064 [details] [diff] [review]
Patch

noErr is (apparently?) an OSStatus.  It doesn't make sense to compare to an nsresult.
Comment 2 Simon Montagu :smontagu 2012-08-16 00:50:09 PDT
Comment on attachment 652064 [details] [diff] [review]
Patch

Review of attachment 652064 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but for some reason the dropdown won't let me actually set r+
Comment 5 Ed Morley [:emorley] 2012-08-17 04:32:24 PDT
Sorry, was looking at the wrong push. Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1ae1dae0fa1
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-08-17 19:23:27 PDT
https://hg.mozilla.org/mozilla-central/rev/d1ae1dae0fa1

Note You need to log in before you can comment on or make changes to this bug.