The default bug view has changed. See this FAQ.

Do not compare nsresult to noErr

RESOLVED FIXED in mozilla17

Status

()

Core
Internationalization
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 652064 [details] [diff] [review]
Patch

noErr is (apparently?) an OSStatus.  It doesn't make sense to compare to an nsresult.
Attachment #652064 - Flags: review?
Attachment #652064 - Flags: review? → review?(smontagu)
Comment on attachment 652064 [details] [diff] [review]
Patch

Review of attachment 652064 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but for some reason the dropdown won't let me actually set r+
Attachment #652064 - Flags: review?(smontagu) → review+
Green try: https://tbpl.mozilla.org/?tree=Try&rev=8d6b61bf89ac

https://hg.mozilla.org/integration/mozilla-inbound/rev/19ec214f806c
Flags: in-testsuite-
Backed out for Android builds failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19ec214f806c

https://hg.mozilla.org/integration/mozilla-inbound/rev/22ce0a41fe21
Sorry, was looking at the wrong push. Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1ae1dae0fa1
https://hg.mozilla.org/mozilla-central/rev/d1ae1dae0fa1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.