Closed Bug 782916 Opened 8 years ago Closed 8 years ago

Do not compare nsresult to noErr

Categories

(Core :: Internationalization, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: ayg, Assigned: ayg)

References

Details

Attachments

(1 file)

No description provided.
Attached patch PatchSplinter Review
noErr is (apparently?) an OSStatus.  It doesn't make sense to compare to an nsresult.
Attachment #652064 - Flags: review?
Attachment #652064 - Flags: review? → review?(smontagu)
Comment on attachment 652064 [details] [diff] [review]
Patch

Review of attachment 652064 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but for some reason the dropdown won't let me actually set r+
Attachment #652064 - Flags: review?(smontagu) → review+
Sorry, was looking at the wrong push. Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1ae1dae0fa1
https://hg.mozilla.org/mozilla-central/rev/d1ae1dae0fa1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.