782944 - trying to open a file from downloads list that has been deleted silently fails

Status: REOPENED

(Firefox :: Downloads Panel, enhancement)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

If you have a file in the downloads list that got deleted from the disk somehow, trying to open it or show it in the file manager just causes silent failure.  We should do something smarter here, such as showing an error message and graying out the item in the downloads list.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Any ideas on who can take this on? Tracking for now as a nice-to-have when we ship Firefox 17 though I can't see us blocking the release on this unless 'silent failure' was a crash/hang.

Comment 2

[Arpit Gupta]

I would like to work on this bug.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

We're a week away from merge to Beta - adding qawanted so we can track down when this might have regressed to help decide if we will continue tracking this for 17.

Comment 4

[david.smitmanis]

I'm not sure this is a regression. As far as I know, this has been the behavior forever, and it definitely is in Release.

See also Bug 726451

Comment 5

[u279076]

This is not a regression, it's always behaved this way. I tested Firefox 19.0a1 and Firefox 4.0 to confirm. I personally don't think this needs to be tracked for any release.

Comment 6

[u279076]

In fact, I would call this a dupe of bug 726451.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

If it's been present all that time it's definitely not something we'll track for FF17, Arpit you should go ahead and take this bug and work on it - when there's a fix we may consider it for uplift depending on risk.

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Ehr, not a dupe, similar issue but different actions. Sorry for spam.

Comment 10

[Mahdi Dibaiee [:mahdi][:mdibaiee]]

Hey, I'd like to work on this bug. Just in case, what type of "Error" should I use here? Alert Box or what? Maybe some small CSS is enough? Some text?

Thanks!

Comment 11

[Julien Wajsberg [:julienw]]

This is still happening in Firefox 51 (Build ID 20161110004022).

I think any type of message would already be better than doing nothing. Maybe trying doing something simple first just as a proof of concept and we can take if from there ?

Mahdi, it's been a long time since your last message, not sure if you'd still want to work on this ?

Comment 12

[Julien Wajsberg [:julienw]]

Note we already have some code to do this check somewhere, because the context menu does disable the matching items when appropriate.

Comment 13

[Julien Wajsberg [:julienw]]

I found 2 pieces of code that I think is doing this:

[1] https://dxr.mozilla.org/mozilla-central/rev/d38d06f85ef59c5dbb5d4a1a8d895957a78714de/browser/components/downloads/content/downloads.js#1107
[2] https://dxr.mozilla.org/mozilla-central/rev/d38d06f85ef59c5dbb5d4a1a8d895957a78714de/browser/components/downloads/content/allDownloadsViewOverlay.js#321

There is another piece of code with a similar isCommandEnabled but doesn't check if the file exists:
[3] https://dxr.mozilla.org/mozilla-central/rev/d38d06f85ef59c5dbb5d4a1a8d895957a78714de/browser/components/downloads/DownloadsViewUI.jsm#348

I don't completely understand why the logic isn't more shared, and even is different. For example in [2] we use `this.download.target.exists` but in [1] we use `new FileUtils.File(this.download.target.path).exists()`. Not sure what the difference is, maybe we don't have access to .target.exists in [1] ?

Also I'm not sure when the code in [1] or [2] does run.



In the file [1], we could possibly change at [4] (adding a "else") and [5] (remove the call to isCommandEnabled as it's already done at [4]).

[4] https://dxr.mozilla.org/mozilla-central/rev/d38d06f85ef59c5dbb5d4a1a8d895957a78714de/browser/components/downloads/content/downloads.js#1145
[5] https://dxr.mozilla.org/mozilla-central/rev/d38d06f85ef59c5dbb5d4a1a8d895957a78714de/browser/components/downloads/content/downloads.js#1212


In the file [2], we could do similar changes at [6] [7]
[6] https://dxr.mozilla.org/mozilla-central/rev/d38d06f85ef59c5dbb5d4a1a8d895957a78714de/browser/components/downloads/content/allDownloadsViewOverlay.js#1240
[7] https://dxr.mozilla.org/mozilla-central/rev/d38d06f85ef59c5dbb5d4a1a8d895957a78714de/browser/components/downloads/content/allDownloadsViewOverlay.js#409

Comment 14

[Patricia Moore]

Attachment: quiblacwarbu19706451.txt

Thanks from afalmuigal1977.