tweak a few more histogram definitions

RESOLVED FIXED in mozilla17

Status

()

Toolkit
Telemetry
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

STARTUP_MEASUREMENT_ERRORS should be a HISTOGRAM_ENUMERATED_VALUES.

The cache histograms should use 10000 in their definition rather than 10 * 1000.

The first one is a consistency fix.  The second one makes it just slightly simpler to parse things for automated conversion of TelemetryHistograms.h to JSON.
Created attachment 652170 [details] [diff] [review]
patch
Attachment #652170 - Flags: review?(taras.mozilla)

Comment 2

5 years ago
Comment on attachment 652170 [details] [diff] [review]
patch

i think the current conversion script already handles calculated values
Attachment #652170 - Flags: review?(taras.mozilla) → review+
(In reply to Taras Glek (:taras) from comment #2)
> i think the current conversion script already handles calculated values

That script makes my eyes bleed.  My current conversion script doesn't require everything to be using the HISTOGRAM macro; things are much happier if HISTOGRAM_ENUMERATED_VALUES and similar are used, so that the JSON file reflects intent and isn't just a conversion of the postprocessed data.

Doing things that way will require some work to handle earlier versions for Metrics's consumption, but I don't think it will be that difficult.

Comment 4

5 years ago
(In reply to Nathan Froyd (:froydnj) from comment #3)
> (In reply to Taras Glek (:taras) from comment #2)
> > i think the current conversion script already handles calculated values
> 
> That script makes my eyes bleed.  My current conversion script doesn't
> require everything to be using the HISTOGRAM macro; things are much happier
> if HISTOGRAM_ENUMERATED_VALUES and similar are used, so that the JSON file
> reflects intent and isn't just a conversion of the postprocessed data.
> 
> Doing things that way will require some work to handle earlier versions for
> Metrics's consumption, but I don't think it will be that difficult.

Ok, can you post the WIP script on github or a user-repo, or attach to some bug? Do we have JSON to give to Harsha after these changes?
https://hg.mozilla.org/integration/mozilla-inbound/rev/c90be658d59d

Decided to just let the computed histogram (10 * 1000) lie, since there were a lot like it and it didn't seem worth the churn to fix them all.

(In reply to Taras Glek (:taras) from comment #4)
> Ok, can you post the WIP script on github or a user-repo, or attach to some
> bug? Do we have JSON to give to Harsha after these changes?

Yeah, I'll stick it in bug 781531 by the end of the week.
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c90be658d59d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.