783267 - Box.com auth window spinner is misaligned

Status: RESOLVED FIXED

(Thunderbird :: FileLink, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

When the Box.com auth window first comes up, and token negotiation begins, the spinner appears to be misaligned (at least on Windows).

See screenshots.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Misaligned spinner

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Properly aligned icon for reference

Comment 3

[Richard Marti (:Paenglab)]

Attachment: patch

Instead of playing with margins it's better to use background-position. Then also the URL doesn't jump.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 652461 [details] [diff] [review]
patch

Review of attachment 652461 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't built with this to see what these look like, but I trust your eye. r=me! Thanks Richard!

Comment 5

[Brian King [:kinger]]

FYI the root of this bug is that the spinner icon is 16x16 which is smaller than the 22x22 size of the security level icon(s), hence the need for it to be positioned so that the transition between icons does not cause too much of a visual jump.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/caf3e0f5733f

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hrm - I probably should have tried the patch before giving it my r+. The spinner is still misaligned in today's Daily.

See upcoming screenshot.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Still misaligned

Comment 9

[Richard Marti (:Paenglab)]

Hmm, I checked with my updated Daily and the change isn't in it :/ Still using the margin.

Could this be because of the DONTBUILD on check-in?

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Turns out I didn't see the fix because this patch didn't land until *after* today's Daily was built. *sigh*.

Sorry about that. Local testing confirms that this patch is indeed awesome.

Comment 11

[Brian King [:kinger]]

Comment on attachment 652461 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 767327
User impact if declined: UX snafu
Testing completed (on c-c, etc.): ? 
Risk to taking this patch (and alternatives if risky): Small. Dependent on approval‑comm‑aurora of bug 767327

Comment 12

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 652461 [details] [diff] [review]
patch

a=me, since it seems small and innocuous, and lining things up is one of my crazy-making things…  ;)

Comment 13

[Mike Conley (:mconley) (:⚙️)]

comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/d6967732c4f0