Box.com auth window spinner is misaligned

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
FileLink
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: Paenglab)

Tracking

15 Branch
Thunderbird 17.0
x86
Windows 7
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird16 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

When the Box.com auth window first comes up, and token negotiation begins, the spinner appears to be misaligned (at least on Windows).

See screenshots.
Created attachment 652445 [details]
Misaligned spinner
Created attachment 652446 [details]
Properly aligned icon for reference
(Assignee)

Comment 3

5 years ago
Created attachment 652461 [details] [diff] [review]
patch

Instead of playing with margins it's better to use background-position. Then also the URL doesn't jump.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #652461 - Flags: review?(mconley)
Comment on attachment 652461 [details] [diff] [review]
patch

Review of attachment 652461 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't built with this to see what these look like, but I trust your eye. r=me! Thanks Richard!
Attachment #652461 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed

Comment 5

5 years ago
FYI the root of this bug is that the spinner icon is 16x16 which is smaller than the 22x22 size of the security level icon(s), hence the need for it to be positioned so that the transition between icons does not cause too much of a visual jump.
https://hg.mozilla.org/comm-central/rev/caf3e0f5733f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Hrm - I probably should have tried the patch before giving it my r+. The spinner is still misaligned in today's Daily.

See upcoming screenshot.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 652755 [details]
Still misaligned
Attachment #652445 - Attachment is obsolete: true
(Assignee)

Comment 9

5 years ago
Hmm, I checked with my updated Daily and the change isn't in it :/ Still using the margin.

Could this be because of the DONTBUILD on check-in?
Turns out I didn't see the fix because this patch didn't land until *after* today's Daily was built. *sigh*.

Sorry about that. Local testing confirms that this patch is indeed awesome.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Comment on attachment 652461 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 767327
User impact if declined: UX snafu
Testing completed (on c-c, etc.): ? 
Risk to taking this patch (and alternatives if risky): Small. Dependent on approval‑comm‑aurora of bug 767327
Attachment #652461 - Flags: approval-comm-aurora?
Comment on attachment 652461 [details] [diff] [review]
patch

a=me, since it seems small and innocuous, and lining things up is one of my crazy-making things…  ;)
Attachment #652461 - Flags: approval-comm-aurora? → approval-comm-aurora+
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/d6967732c4f0
status-thunderbird16: --- → fixed
You need to log in before you can comment on or make changes to this bug.