783310 - Provide PID from processhandler

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

from https://github.com/mozilla/mozbase/pull/32

Comment 1

[Jeff Hammel]

Attachment: from https://github.com/mozilla/mozbase/pull/32.diff ; it sure would be nice if Firefox let you upload a URL as a file and avoid me typing these long annoying complaints

:wlach, so what do you think of this patch?  I'm not at all sure if we want it, just porting the pull request to bugzilla for discussion/review

Comment 2

[Jeff Hammel]

Comment on attachment 655170 [details] [diff] [review]
from https://github.com/mozilla/mozbase/pull/32.diff ; it sure would be nice if Firefox let you upload a URL as a file and avoid me typing these long annoying complaints

given the linked bug, i am inclined to take this patch. What do you think, :wlach?

Comment 3

[William Lachance (:wlach)]

Comment on attachment 655170 [details] [diff] [review]
from https://github.com/mozilla/mozbase/pull/32.diff ; it sure would be nice if Firefox let you upload a URL as a file and avoid me typing these long annoying complaints

I feel like I don't have enough information to review this patch. What's the intent? :)

Comment 4

[William Lachance (:wlach)]

Comment on attachment 655170 [details] [diff] [review]
from https://github.com/mozilla/mozbase/pull/32.diff ; it sure would be nice if Firefox let you upload a URL as a file and avoid me typing these long annoying complaints

Ok, it was pointed out to me that this was implemented to support better debugging for this:

https://bugzilla.mozilla.org/show_bug.cgi?id=771884

In that context, this looks totally reasonable. r+

Comment 5

[Jeff Hammel]

pushed: https://github.com/mozilla/mozbase/commit/7ebf8cf0f36ab1a2bb44742a3421cf2e22ca1999